[ArgoCD] Fixing webhook typo in case of error in GetManifests (#9671)

nfillot · Nicolas Fillot · crenshaw-dev · commit 068ca899ce48 · 2022-06-23T09:27:06.000-04:00
Signed-off-by: Nicolas Fillot &lt;nfillot@weborama.com&gt;

Co-authored-by: Nicolas Fillot &lt;nfillot@weborama.com&gt;
Signed-off-by: Michael Crenshaw &lt;michael@crenshaw.dev&gt;
diff --git a/util/webhook/webhook.go b/util/webhook/webhook.go
@@ -283,7 +283,7 @@ func (a *ArgoCDWebhookHandler) storePreviouslyCachedManifests(app *v1alpha1.Appl
 		return err
 	}
 	var cachedManifests cache.CachedManifestResponse
-	if err := a.repoCache.GetManifests(change.shaBefore, &app.Spec.Source, &clusterInfo, app.Spec.Destination.Namespace, trackingMethod, appInstanceLabelKey, app.Name, &cachedManifests); err == nil {
+	if err := a.repoCache.GetManifests(change.shaBefore, &app.Spec.Source, &clusterInfo, app.Spec.Destination.Namespace, trackingMethod, appInstanceLabelKey, app.Name, &cachedManifests); err != nil {
 		return err
 	}
 	if err = a.repoCache.SetManifests(change.shaAfter, &app.Spec.Source, &clusterInfo, app.Spec.Destination.Namespace, trackingMethod, appInstanceLabelKey, app.Name, &cachedManifests); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -283,7 +283,7 @@ func (a ArgoCDWebhookHandler) storePreviouslyCachedManifests(app v1alpha1.Appl`
`283`	`283`	`return err`
`284`	`284`	`}`
`285`	`285`	`var cachedManifests cache.CachedManifestResponse`
`286`		`- if err := a.repoCache.GetManifests(change.shaBefore, &app.Spec.Source, &clusterInfo, app.Spec.Destination.Namespace, trackingMethod, appInstanceLabelKey, app.Name, &cachedManifests); err == nil {`
	`286`	`+ if err := a.repoCache.GetManifests(change.shaBefore, &app.Spec.Source, &clusterInfo, app.Spec.Destination.Namespace, trackingMethod, appInstanceLabelKey, app.Name, &cachedManifests); err != nil {`
`287`	`287`	`return err`
`288`	`288`	`}`
`289`	`289`	`if err = a.repoCache.SetManifests(change.shaAfter, &app.Spec.Source, &clusterInfo, app.Spec.Destination.Namespace, trackingMethod, appInstanceLabelKey, app.Name, &cachedManifests); err != nil {`