Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the possibility to overwrite services #14

Closed
arobirosa opened this issue Mar 23, 2021 · 3 comments
Closed

Improve the possibility to overwrite services #14

arobirosa opened this issue Mar 23, 2021 · 3 comments
Assignees
Labels
accepted Bug can be reproduced or enhancement is useful for other users enhancement New feature or request good first issue Good for newcomers in-progress In progress priorityLow No reduction of the functionality of the extension
Milestone

Comments

@arobirosa
Copy link
Owner

Is your feature request related to a problem? Please describe.
I want to create a new implementation of the localizedImpexService and it is difficult to overwirte the bean and at the same time create a decorator.

Describe the solution you'd like
Beans without autowiring with bean aliases.

Describe alternatives you've considered
Duplicate the bean creation.

Additional context

@arobirosa arobirosa added the enhancement New feature or request label Mar 23, 2021
@arobirosa arobirosa modified the milestone: 1.5.4 Apr 9, 2021
@arobirosa
Copy link
Owner Author

The PropertyFileDeploymentScriptConfigurationReader and PropertyFileDeploymentScriptConfiguration must be more extension friendly. They currently have too many private methods which can have protected access.

@arobirosa arobirosa self-assigned this Apr 9, 2021
@arobirosa arobirosa added accepted Bug can be reproduced or enhancement is useful for other users priorityLow No reduction of the functionality of the extension labels Apr 9, 2021
@arobirosa arobirosa added the good first issue Good for newcomers label Feb 15, 2023
@arobirosa arobirosa added this to the 1.5.5 milestone Feb 16, 2023
@arobirosa arobirosa removed their assignment Feb 23, 2023
@arobirosa arobirosa self-assigned this Nov 1, 2023
@arobirosa arobirosa added the in-progress In progress label Nov 1, 2023
@arobirosa
Copy link
Owner Author

I will only change the 3 named classes because it would be too risky to replace the autowiring by type with one by name. This change will surely break any project where the Areco Deployment Manager was customized.

@arobirosa
Copy link
Owner Author

Now those classes and the ArecoDeploymentScriptsRunner can be easily overwritten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Bug can be reproduced or enhancement is useful for other users enhancement New feature or request good first issue Good for newcomers in-progress In progress priorityLow No reduction of the functionality of the extension
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant