Skip to content

Commit 6b19b66

Browse files
natisbadgroeck
authored andcommitted
hwmon: (g762) fix call to devm_hwmon_device_register_with_groups()
g762_remove() needs to first call hwmon_device_unregister() and then g762_of_clock_disable(). For that reason, it is not possible to convert it to devm_hwmon_device_register_with_groups() and the the non device managed version must be used. This is correctly stated in commit message for 398e16d ("hwmon: (g762) Convert to hwmon_device_register_with_groups") but the associated changes do in fact introduce a call to the device managed version of the function. This patch fixes that typo by switching to the non devm_ version. Fixes: 398e16d ("hwmon: (g762) Convert to hwmon_device_register_with_groups") Cc: stable@vger.kernel.org (3.17+) Signed-off-by: Arnaud Ebalard <arno@natisbad.org> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent fc14f9c commit 6b19b66

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/hwmon/g762.c

+2-4
Original file line numberDiff line numberDiff line change
@@ -1084,10 +1084,8 @@ static int g762_probe(struct i2c_client *client, const struct i2c_device_id *id)
10841084
if (ret)
10851085
goto clock_dis;
10861086

1087-
data->hwmon_dev = devm_hwmon_device_register_with_groups(dev,
1088-
client->name,
1089-
data,
1090-
g762_groups);
1087+
data->hwmon_dev = hwmon_device_register_with_groups(dev, client->name,
1088+
data, g762_groups);
10911089
if (IS_ERR(data->hwmon_dev)) {
10921090
ret = PTR_ERR(data->hwmon_dev);
10931091
goto clock_dis;

0 commit comments

Comments
 (0)