Skip to content

Commit db2016e

Browse files
yeohbraddyhauck-jvshBraddy Yeoh
authored andcommitted
Pre-commit checks now check for missing javadoc, and the Gradle check Jenkins build now waits for pre-commit checks to pass before attempting (opensearch-project#4660)
* Ignore all malformed objects when ignore_malformed is true (opensearch-project#4494) Fixes a bug to not fail the entire document when "ignore_malformed" is set to true. Allowing the valid fields to be indexed and ignore only the malformed fields. Signed-off-by: Hauck <joaoh14@gmail.com> Signed-off-by: Braddy Yeoh <braddy.yeoh@ucdconnect.ie> * Adding javadoc check to the precommi\t GitHub Action Signed-off-by: Braddy Yeoh <braddy.yeoh@ucdconnect.ie> * gradle check now only runs after successful gradle precommit check Signed-off-by: Braddy Yeoh <braddy.yeoh@ucdconnect.ie> * Added to CHANGELOG Signed-off-by: Braddy Yeoh yeohbraddy@gmail.com Signed-off-by: Braddy Yeoh <braddy.yeoh@ucdconnect.ie> Signed-off-by: Hauck <joaoh14@gmail.com> Signed-off-by: Braddy Yeoh <braddy.yeoh@ucdconnect.ie> Signed-off-by: Braddy Yeoh yeohbraddy@gmail.com Co-authored-by: Hauck <67768441+hauck-jvsh@users.noreply.github.com> Co-authored-by: Braddy Yeoh <braddy.yeoh@ucdconnect.ie>
1 parent 49215b5 commit db2016e

File tree

3 files changed

+17
-2
lines changed

3 files changed

+17
-2
lines changed

.github/workflows/gradle-check.yml

+5
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,15 @@ on:
77
- 'dependabot/**'
88
pull_request_target:
99
types: [opened, synchronize, reopened]
10+
workflow_run:
11+
workflows: [Gradle Precommit]
12+
types:
13+
- completed
1014

1115
jobs:
1216
gradle-check:
1317
runs-on: ubuntu-latest
18+
if: ${{ github.event.workflow_run.conclusion == 'success' }}
1419
timeout-minutes: 130
1520
steps:
1621
- name: Checkout OpenSearch repo

.github/workflows/precommit.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ jobs:
1313
distribution: adopt
1414
- name: Run Gradle
1515
run: |
16-
./gradlew precommit --parallel
16+
./gradlew javadoc precommit --parallel

CHANGELOG.md

+11-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
# CHANGELOG
2+
23
Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
34

45
## [Unreleased]
6+
57
### Added
8+
69
- Add support for s390x architecture ([#4001](https://github.com/opensearch-project/OpenSearch/pull/4001))
710
- Github workflow for changelog verification ([#4085](https://github.com/opensearch-project/OpenSearch/pull/4085))
811
- Point in time rest layer changes for create and delete PIT API ([#4064](https://github.com/opensearch-project/OpenSearch/pull/4064))
@@ -44,6 +47,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
4447
- Bumps `hadoop-hdfs` from 3.3.3 to 3.3.4 ([#4644](https://github.com/opensearch-project/OpenSearch/pull/4644))
4548

4649
### Changed
50+
4751
- Dependency updates (httpcore, mockito, slf4j, httpasyncclient, commons-codec) ([#4308](https://github.com/opensearch-project/OpenSearch/pull/4308))
4852
- Use RemoteSegmentStoreDirectory instead of RemoteDirectory ([#4240](https://github.com/opensearch-project/OpenSearch/pull/4240))
4953
- Plugin ZIP publication groupId value is configurable ([#4156](https://github.com/opensearch-project/OpenSearch/pull/4156))
@@ -59,15 +63,18 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
5963
- Relax visibility of the HTTP_CHANNEL_KEY and HTTP_SERVER_CHANNEL_KEY to make it possible for the plugins to access associated Netty4HttpChannel / Netty4HttpServerChannel instance ([#4638](https://github.com/opensearch-project/OpenSearch/pull/4638))
6064
- Load the deprecated master role in a dedicated method instead of in setAdditionalRoles() ([#4582](https://github.com/opensearch-project/OpenSearch/pull/4582))
6165
- Add APIs (GET/PUT) to decommission awareness attribute ([#4261](https://github.com/opensearch-project/OpenSearch/pull/4261))
66+
- Improve Gradle pre-commit checks to pre-empt Jenkins build ([#4660](https://github.com/opensearch-project/OpenSearch/pull/4660))
6267
- Update to Apache Lucene 9.4.0 ([#4661](https://github.com/opensearch-project/OpenSearch/pull/4661))
6368

69+
6470
### Deprecated
6571

6672
### Removed
6773
- Remove deprecated code to add node name into log pattern of log4j property file ([#4568](https://github.com/opensearch-project/OpenSearch/pull/4568))
6874
- Unused object and import within TransportClusterAllocationExplainAction ([#4639](https://github.com/opensearch-project/OpenSearch/pull/4639))
6975

7076
### Fixed
77+
7178
- `opensearch-service.bat start` and `opensearch-service.bat manager` failing to run ([#4289](https://github.com/opensearch-project/OpenSearch/pull/4289))
7279
- PR reference to checkout code for changelog verifier ([#4296](https://github.com/opensearch-project/OpenSearch/pull/4296))
7380
- `opensearch.bat` and `opensearch-service.bat install` failing to run, missing logs directory ([#4305](https://github.com/opensearch-project/OpenSearch/pull/4305))
@@ -104,10 +111,13 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
104111
- [Bug]: Alias filter lost after rollover ([#4499](https://github.com/opensearch-project/OpenSearch/pull/4499))
105112

106113
### Security
114+
107115
- CVE-2022-25857 org.yaml:snakeyaml DOS vulnerability ([#4341](https://github.com/opensearch-project/OpenSearch/pull/4341))
108116

109117
## [2.x]
118+
110119
### Added
120+
111121
- Github workflow for changelog verification ([#4085](https://github.com/opensearch-project/OpenSearch/pull/4085))
112122
- Label configuration for dependabot PRs ([#4348](https://github.com/opensearch-project/OpenSearch/pull/4348))
113123
- Added RestLayer Changes for PIT stats ([#4217](https://github.com/opensearch-project/OpenSearch/pull/4217))
@@ -123,11 +133,11 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
123133
### Removed
124134

125135
### Fixed
136+
126137
- PR reference to checkout code for changelog verifier ([#4296](https://github.com/opensearch-project/OpenSearch/pull/4296))
127138
- Commit workflow for dependabot changelog helper ([#4331](https://github.com/opensearch-project/OpenSearch/pull/4331))
128139

129140
### Security
130141

131-
132142
[Unreleased]: https://github.com/opensearch-project/OpenSearch/compare/2.2.0...HEAD
133143
[2.x]: https://github.com/opensearch-project/OpenSearch/compare/2.2.0...2.x

0 commit comments

Comments
 (0)