Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online code preview #114

Closed
Kijewski opened this issue Aug 5, 2024 · 12 comments
Closed

Online code preview #114

Kijewski opened this issue Aug 5, 2024 · 12 comments

Comments

@Kijewski
Copy link
Collaborator

Kijewski commented Aug 5, 2024

What do you think, @GuillaumeGomez, could https://kijewski.github.io/play-rinja/ / https://github.com/Kijewski/play-rinja/ be interesting to someone? If it could be (made) interesting, then I'd move it into the organization.

Right now, it's more or less a prove-of-concept.

@GuillaumeGomez
Copy link
Collaborator

It would be useful to me for sure!

@Kijewski
Copy link
Collaborator Author

Kijewski commented Aug 5, 2024

Moved: https://github.com/rinja-rs/play-rinja + https://rinja-rs.github.io/play-rinja :)

But it seems like I lost my ownership during the transfer, and I also didn't get it back through the org. I hope do can do settings changes and re-invite me. :D I.e. I can modify the code, but I can't modify the displayed URL.

@GuillaumeGomez
Copy link
Collaborator

Don't you have admin rights to do so normally already?

@GuillaumeGomez
Copy link
Collaborator

Ah no, you were admin only on this repository. You're now admin of the organization directly.

@Kijewski
Copy link
Collaborator Author

Kijewski commented Aug 5, 2024

Ahh, thank you! :)

@GuillaumeGomez
Copy link
Collaborator

Well it was a mistake on my end so now it's fixed at least. :)

@Kijewski
Copy link
Collaborator Author

Kijewski commented Aug 7, 2024

https://rinja-rs.github.io/play-rinja/ is pretty, now. :)

@GuillaumeGomez
Copy link
Collaborator

It is indeed! Maybe you might want to add a "generate" button to reduce load on your server too.

@Kijewski
Copy link
Collaborator Author

Kijewski commented Aug 8, 2024

All the code generation, highlighting, etc., is all done in the browse in Wasm. No data is transferred. That's why I needed #111 and #117. :)

@GuillaumeGomez
Copy link
Collaborator

Oh wow. That's SUPER cool!

@GuillaumeGomez
Copy link
Collaborator

Well, just open a PR to add links to your playground then so we can sell even more rinja to the world. :D

@Kijewski
Copy link
Collaborator Author

Kijewski commented Aug 8, 2024

Resolved in #120.

@Kijewski Kijewski closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants