Skip to content

Commit dc6f639

Browse files
Rename list-reassign-reversed to list-reverse-copy (#10514)
After discussion with @MichaReiser.
1 parent 01fe268 commit dc6f639

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

crates/ruff_linter/src/checkers/ast/analyze/statement.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1503,7 +1503,7 @@ pub(crate) fn statement(stmt: &Stmt, checker: &mut Checker) {
15031503
}
15041504
}
15051505
}
1506-
if checker.enabled(Rule::ListAssignReversed) {
1506+
if checker.enabled(Rule::ListReverseCopy) {
15071507
refurb::rules::list_assign_reversed(checker, assign);
15081508
}
15091509
}

crates/ruff_linter/src/codes.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1056,7 +1056,7 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
10561056
(Refurb, "177") => (RuleGroup::Preview, rules::refurb::rules::ImplicitCwd),
10571057
(Refurb, "180") => (RuleGroup::Preview, rules::refurb::rules::MetaClassABCMeta),
10581058
(Refurb, "181") => (RuleGroup::Preview, rules::refurb::rules::HashlibDigestHex),
1059-
(Refurb, "187") => (RuleGroup::Preview, rules::refurb::rules::ListAssignReversed),
1059+
(Refurb, "187") => (RuleGroup::Preview, rules::refurb::rules::ListReverseCopy),
10601060

10611061
// flake8-logging
10621062
(Flake8Logging, "001") => (RuleGroup::Stable, rules::flake8_logging::rules::DirectLoggerInstantiation),

crates/ruff_linter/src/rules/refurb/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ mod tests {
3535
#[test_case(Rule::RedundantLogBase, Path::new("FURB163.py"))]
3636
#[test_case(Rule::MetaClassABCMeta, Path::new("FURB180.py"))]
3737
#[test_case(Rule::HashlibDigestHex, Path::new("FURB181.py"))]
38-
#[test_case(Rule::ListAssignReversed, Path::new("FURB187.py"))]
38+
#[test_case(Rule::ListReverseCopy, Path::new("FURB187.py"))]
3939
fn rules(rule_code: Rule, path: &Path) -> Result<()> {
4040
let snapshot = format!("{}_{}", rule_code.noqa_code(), path.to_string_lossy());
4141
let diagnostics = test_path(

crates/ruff_linter/src/rules/refurb/rules/list_assign_reversed.rs crates/ruff_linter/src/rules/refurb/rules/list_reverse_copy.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -39,19 +39,19 @@ use crate::checkers::ast::Checker;
3939
/// ## References
4040
/// - [Python documentation: More on Lists](https://docs.python.org/3/tutorial/datastructures.html#more-on-lists)
4141
#[violation]
42-
pub struct ListAssignReversed {
42+
pub struct ListReverseCopy {
4343
name: String,
4444
}
4545

46-
impl AlwaysFixableViolation for ListAssignReversed {
46+
impl AlwaysFixableViolation for ListReverseCopy {
4747
#[derive_message_formats]
4848
fn message(&self) -> String {
49-
let ListAssignReversed { name } = self;
49+
let ListReverseCopy { name } = self;
5050
format!("Use of assignment of `reversed` on list `{name}`")
5151
}
5252

5353
fn fix_title(&self) -> String {
54-
let ListAssignReversed { name } = self;
54+
let ListReverseCopy { name } = self;
5555
format!("Replace with `{name}.reverse()`")
5656
}
5757
}
@@ -83,7 +83,7 @@ pub(crate) fn list_assign_reversed(checker: &mut Checker, assign: &StmtAssign) {
8383

8484
checker.diagnostics.push(
8585
Diagnostic::new(
86-
ListAssignReversed {
86+
ListReverseCopy {
8787
name: target_expr.id.to_string(),
8888
},
8989
assign.range(),

crates/ruff_linter/src/rules/refurb/rules/mod.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ pub(crate) use hashlib_digest_hex::*;
55
pub(crate) use if_expr_min_max::*;
66
pub(crate) use implicit_cwd::*;
77
pub(crate) use isinstance_type_none::*;
8-
pub(crate) use list_assign_reversed::*;
8+
pub(crate) use list_reverse_copy::*;
99
pub(crate) use math_constant::*;
1010
pub(crate) use metaclass_abcmeta::*;
1111
pub(crate) use print_empty_string::*;
@@ -28,7 +28,7 @@ mod hashlib_digest_hex;
2828
mod if_expr_min_max;
2929
mod implicit_cwd;
3030
mod isinstance_type_none;
31-
mod list_assign_reversed;
31+
mod list_reverse_copy;
3232
mod math_constant;
3333
mod metaclass_abcmeta;
3434
mod print_empty_string;

0 commit comments

Comments
 (0)