Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV- Dag only deploy flag is disabled by default #1344

Closed
1 task
shri-astro opened this issue Aug 7, 2023 · 1 comment
Closed
1 task

DEV- Dag only deploy flag is disabled by default #1344

shri-astro opened this issue Aug 7, 2023 · 1 comment
Assignees

Comments

@shri-astro
Copy link

As per the latest change in the dag deploy default boolean value for deployment creation under hosted and shared, the dag deploy flag should be true by default.
The following CLI operation in the latest version indicates that the dag deploy flag is set to false by default during deployment creation from CLI
Reference PR: https://github.com/astronomer/astro/pull/15168

shrividyahegde@Shrividyas-MacBook-Pro ~ % astro deployment create -n "Test dag deploy"
Current Workspace: Astro_hosted_CLI_Automation_Restricted_Workspace


Please select a Region for your Deployment:
 #     REGION           
 1     europe-west4     
 2     us-east4         
 3     us-central1      

> 2
 NAME                NAMESPACE     CLUSTER      DEPLOYMENT ID                  RUNTIME VERSION                    DAG DEPLOY ENABLED     CI-CD ENFORCEMENT     
 Test dag deploy     N/A           us-east4     cll0vdjf7630591bvfrgjcqsjv     8.8.0 (based on Airflow 2.6.3)     false                  false                 

 Successfully created Deployment: Test dag deploy
 Deployment can be accessed at the following URLs 

 Deployment Dashboard: cloud.astronomer-dev.io/clkmpjzfk002d01m8vnpg1tu7/deployments/cll0vdjf7630591bvfrgjcqsjv/analytics
 Airflow Dashboard: org-shri-hosted-dedicated-1.astronomer-dev.run/dgjcqsjv
shrividyahegde@Shrividyas-MacBook-Pro ~ % 

What CLI Version did you experience this bug?
1.18.1

This CLI bug is related to which Astronomer Platform?

  • Astro
@shri-astro
Copy link
Author

shri-astro commented Aug 10, 2023

Retested on the pre-release version:
Retest results as expected.

shrividyahegde@Shrividyas-MacBook-Pro astro_1.18.2_darwin_arm64 % ./astro version
Astro CLI Version: 1.18.2
shrividyahegde@Shrividyas-MacBook-Pro astro_1.18.2_darwin_arm64 % ./astro deployment create -n "Test dag deploy"
Current Workspace: Astro_hosted_CLI_Automation_Restricted_Workspace


Please select a Region for your Deployment:
 #     REGION           
 1     europe-west4     
 2     us-east4         
 3     us-central1      

> 2
 NAME                NAMESPACE     CLUSTER      DEPLOYMENT ID                  RUNTIME VERSION                    DAG DEPLOY ENABLED     CI-CD ENFORCEMENT     
 Test dag deploy     N/A           us-east4     cll4si9u9779201uyxs5epxu8i     8.8.0 (based on Airflow 2.6.3)     true                   false                 

 Successfully created Deployment: Test dag deploy
 Deployment can be accessed at the following URLs 

 Deployment Dashboard: cloud.astronomer-dev.io/clkmpjzfk002d01m8vnpg1tu7/deployments/cll4si9u9779201uyxs5epxu8i/analytics
 Airflow Dashboard: org-shri-hosted-dedicated-1.astronomer-dev.run/d5epxu8i
shrividyahegde@Shrividyas-MacBook-Pro astro_1.18.2_darwin_arm64 % ./astro deployment create -n "Test dag deploy" --cluster-type dedicated
Current Workspace: Astro_hosted_CLI_Automation_Restricted_Workspace


Please select a Cluster for your Deployment:
#      CLUSTER NAME                                                CLOUD PROVIDER     CLUSTER ID                    
1      Dedicated cluster for deployment testing13:24:05.294775     aws                clky1q7sw007001iblja49g7e     
2      Dedicated cluster for deployment testing13:24:14.971010     aws                clkwmakjn00ur01qtmlyobrj3     
3      Dedicated cluster for deployment testing12:45:01.662505     aws                clkqv4q1h00d401pgomhum8l8     
4      Dedicated cluster for deployment testing10:16:29.559415     aws                clkqptphw007p01pz84m0v7ey     
5      Dedicated cluster for runtime testing16:20:43.240652        aws                clkmgq8s300jq01j1c37jg7y3     
6      Dedicated cluster for runtime testing10:13:36.680193        aws                clkmfeg1y002901icu0y6bqdb     
7      Dedicated cluster for runtime testing08:45:15.014624        aws                clje1lekd00dj01lvrydn0ygg     
8      Dedicated cluster for runtime testing11:41:03.428591        aws                clj47sj4h00u101m9ptlcqgws     
9      Dedicated cluster for runtime testing10:41:24.717731        aws                clj45ntrz00qk01kql31p2y3a     
10     Dedicated cluster for runtime testing22:12:59.724223        aws                cliku7a6o000f01moq4thtxlw     

> 1
NAME                NAMESPACE     CLUSTER                                                     DEPLOYMENT ID                  RUNTIME VERSION                    DAG DEPLOY ENABLED     CI-CD ENFORCEMENT     
Test dag deploy     N/A           Dedicated cluster for deployment testing13:24:05.294775     cll4sjjea781931uyxd1ubsus5     8.8.0 (based on Airflow 2.6.3)     true                   false                 

Successfully created Deployment: Test dag deploy
Deployment can be accessed at the following URLs 

Deployment Dashboard: cloud.astronomer-dev.io/clkmpjzfk002d01m8vnpg1tu7/deployments/cll4sjjea781931uyxd1ubsus5/analytics
Airflow Dashboard: org-shri-hosted-dedicated-1.astronomer-dev.run/d1ubsus5
shrividyahegde@Shrividyas-MacBook-Pro astro_1.18.2_darwin_arm64 % 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants