Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

astro deployment airflow-variable has started giving 404 on all deployments #1438

Closed
1 of 3 tasks
adammarples opened this issue Nov 8, 2023 · 5 comments
Closed
1 of 3 tasks

astro deployment airflow-variable has started giving 404 on all deployments #1438

adammarples opened this issue Nov 8, 2023 · 5 comments
Assignees
@kushalmalani

Comments

@adammarples
Copy link

adammarples commented Nov 8, 2023 •
edited
Loading

Describe the bug

astro deployment airflow-variable list
astro deployment airflow-variable create
astro deployment connection list
astro deployment connection create

are raising errors on all deployments and using different versions of astro-cli

> astro deployment airflow-variable list --deployment-id clopi2lqt5982583oznk8kj25p5                   
Using an Astro API Token
Error: failed to decode response from API

astro deployment airflow-variable create --deployment-id clopi2lqt5982583oznk8kj25p5 --key 'a' --value 'b'
Using an Astro API Token
Creating variable a
Error: API error (404): 

<!DOCTYPE html>
<html lang="en">
  <head>
    <title>Airflow 404</title>
    <link rel="icon" type="image/png" href="https://cdn.astronomer.io/airflow/pin_32.5e56a23472220ff6b3b7.png">
  </head>
  <body>
    <div style="font-family: verdana; text-align: center; margin-top: 200px;">
      <img src="https://cdn.astronomer.io/airflow/pin_100.2da334cc389b24494079.png" width="50px" alt="pin-logo" />
      <h1>Airflow 404</h1>
      <p>Page cannot be found.</p>
      <a href="/">Return to the main page</a>
      <p>redact</p>
    </div>
  </body>
</html>

astro deployment connection list 
Using an Astro API Token
Select a Deployment
 #     DEPLOYMENT NAME     RELEASE NAME                     DEPLOYMENT ID                   DAG DEPLOY ENABLED     
 1     PR_TEST_DBT_72      infrared-transit-5268            clopi2lqt5982583oznk8kj25p5     true                   
 2     PR_TEST_DBT_78      ecliptical-spectroscope-6337     clopi2m575983653oznvbo7yp0t     true                   
 3     PR_TEST_DBT_79      galactic-frequency-3469          clopkk2rl6977921u4jhkq2ok6n     true                   

> 1
Error: failed to decode response from API

The API token itself is not an issure because other astro commands work fine, just airflow-variable and airflow-connection commands don't

What CLI Version did you experience this bug?

v1.17.0
v1.20.0

This CLI bug is related to which Astronomer Platform?

  • Astro
  • Software
  • None/Unknown

What Operating System is the above CLI installed on?

MacOS Sonoma

🪜 Steps To Reproduce

run
astro deployment airflow-variable list
or any of the astro deployment airflow-variable group commands
@adammarples
Copy link
Author

Looking at the network traffic

astro deployment connections list

Is redirecting first to a slightly different url, then to home

308 $webserver_url?orgId=org_$ORGID/api/v1/connections
302 $webserver_url/?orgId=org_$ORGID/api/v1/connections
200 $webserver_url/home

For some reason I'm just getting redirected to /home instead of returning the list of connections

astro deployment airflow-variable create --deployment-id clopi2lqt5982583oznk8kj25p5 --key 'a' --value 'b'

404 $webserver_url?orgId=org_$ORGID/api/v1/variables

@kushalmalani kushalmalani mentioned this issue Nov 8, 2023
Merged
8 tasks
@kushalmalani kushalmalani self-assigned this Nov 8, 2023
@kushalmalani
Copy link
Contributor

@adammarples Fix is patched in release 1.20.1. Can you confirm if it looks good

@sunkickr sunkickr closed this as completed Nov 8, 2023
@adammarples
Copy link
Author

Thanks @kushalmalani the fix looks good but I'm not sure why v1.17.0 of the tool suddenly stopped working with v1 of the API?

@kushalmalani
Copy link
Contributor

@adammarples The issue was on our side. We are transitioning our backend services and we had a regression. We wanted to fix forward because cli would have run into this again. Apologies for the inconvenience.

@adammarples
Copy link
Author

Thanks for the quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kushalmalani kushalmalani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adammarples @sunkickr @kushalmalani