From 5f5669f1a4bcecc28a9d3a60b00799d6a3edcfd1 Mon Sep 17 00:00:00 2001 From: Artem Fedorych <103068102+afastronomer@users.noreply.github.com> Date: Mon, 28 Aug 2023 13:29:40 -0400 Subject: [PATCH 1/2] if statement for version check fix if statement for version check fix --- godownloader.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/godownloader.sh b/godownloader.sh index 8793a95e6..cf46af9ff 100755 --- a/godownloader.sh +++ b/godownloader.sh @@ -300,9 +300,9 @@ http_copy() { github_release() { owner_repo=$1 version=$2 - if [[ $version = "" ]]; then + if [ -z $version ]; then version=$(curl https://api.github.com/repos/${owner_repo}/releases/latest -s | tr -s '\n' ' ' | sed 's/.*"tag_name": "//' | sed 's/".*//') - elif [[ "$version" =~ ^v[0-9]+\.[0-9]+$ ]]; then + elif [ $version = ^v[0-9]+\.[0-9]+$ ]; then escaped_version=$(echo $version | sed -e 's/[]\/$*.^[]/\\&/g') # escape the version string version=$(curl https://api.github.com/repos/${owner_repo}/releases -s | grep ''\"$escaped_version'\.[0-9]"' -m1 | sed 's/.*"tag_name": "//' | sed 's/".*//') else From 7a824a741c32213326253e8a1fe0ad9c48e83b42 Mon Sep 17 00:00:00 2001 From: Artem Fedorych <103068102+afastronomer@users.noreply.github.com> Date: Tue, 29 Aug 2023 09:30:56 -0400 Subject: [PATCH 2/2] verified if statement by customer --- godownloader.sh | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/godownloader.sh b/godownloader.sh index cf46af9ff..5e5cadcd6 100755 --- a/godownloader.sh +++ b/godownloader.sh @@ -302,12 +302,9 @@ github_release() { version=$2 if [ -z $version ]; then version=$(curl https://api.github.com/repos/${owner_repo}/releases/latest -s | tr -s '\n' ' ' | sed 's/.*"tag_name": "//' | sed 's/".*//') - elif [ $version = ^v[0-9]+\.[0-9]+$ ]; then - escaped_version=$(echo $version | sed -e 's/[]\/$*.^[]/\\&/g') # escape the version string - version=$(curl https://api.github.com/repos/${owner_repo}/releases -s | grep ''\"$escaped_version'\.[0-9]"' -m1 | sed 's/.*"tag_name": "//' | sed 's/".*//') else escaped_version=$(echo $version | sed -e 's/[]\/$*.^[]/\\&/g') # escape the version string - version=$(curl https://api.github.com/repos/${owner_repo}/releases -s | grep ''\"$escaped_version\"'' -m1 | sed 's/.*"tag_name": "//' | sed 's/".*//') + version=$(curl https://api.github.com/repos/${owner_repo}/releases -s | grep ''\"$escaped_version\.\*\"'' -m1 | sed 's/.*"tag_name": "//' | sed 's/".*//') fi test -z "$version" && return 1 echo "$version"