Skip to content

Commit 98b5bb6

Browse files
authored
Merge pull request #1047 from asynkron/more-logging-remote
more logging
2 parents 769d317 + 967933a commit 98b5bb6

File tree

3 files changed

+19
-11
lines changed

3 files changed

+19
-11
lines changed

actor/future_test.go

+17
Original file line numberDiff line numberDiff line change
@@ -117,3 +117,20 @@ func TestFuture_Result_Success(t *testing.T) {
117117
resp := assertFutureSuccess(future, t)
118118
a.Equal(EchoResponse{}, resp)
119119
}
120+
121+
func testWork(ctx Context) {
122+
if _, ok := ctx.Message().(string); ok {
123+
ctx.Respond("pong")
124+
}
125+
}
126+
127+
func BenchmarkProto(b *testing.B) {
128+
system := NewActorSystem()
129+
pid := system.Root.Spawn(PropsFromFunc(testWork))
130+
for i := 0; i < b.N; i++ {
131+
_, err := system.Root.RequestFuture(pid, "ping", time.Second).Result()
132+
if err != nil {
133+
panic(err)
134+
}
135+
}
136+
}

actor/mailbox.go

-11
Original file line numberDiff line numberDiff line change
@@ -61,17 +61,6 @@ func (m *defaultMailbox) PostUserMessage(message interface{}) {
6161
}
6262
}
6363

64-
// is it an envelope batch message?
65-
// FIXME: check if this is still needed, maybe MessageEnvelope can only exist as a pointer
66-
if env, ok := message.(MessageEnvelope); ok {
67-
if batch, ok := env.Message.(MessageBatch); ok {
68-
messages := batch.GetMessages()
69-
70-
for _, msg := range messages {
71-
m.PostUserMessage(msg)
72-
}
73-
}
74-
}
7564
if env, ok := message.(*MessageEnvelope); ok {
7665
if batch, ok := env.Message.(MessageBatch); ok {
7766
messages := batch.GetMessages()

remote/endpoint_reader.go

+2
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ func (s *endpointReader) Receive(stream Remoting_ReceiveServer) error {
3939
disconnectChan := make(chan bool, 1)
4040
s.remote.edpManager.endpointReaderConnections.Store(stream, disconnectChan)
4141
defer func() {
42+
s.remote.Logger().Info("EndpointReader is closing")
4243
close(disconnectChan)
4344
}()
4445

@@ -88,6 +89,7 @@ func (s *endpointReader) Receive(stream Remoting_ReceiveServer) error {
8889
m := t.MessageBatch
8990
err := s.onMessageBatch(m)
9091
if err != nil {
92+
s.remote.Logger().Error("EndpointReader failed to handle message batch", slog.Any("error", err))
9193
return err
9294
}
9395
default:

0 commit comments

Comments
 (0)