Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove our workspace size checking #38

Closed
hobofan opened this issue Mar 3, 2016 · 1 comment
Closed

Remove our workspace size checking #38

hobofan opened this issue Mar 3, 2016 · 1 comment

Comments

@hobofan
Copy link
Member

hobofan commented Mar 3, 2016

We originally wanted to remove the somewhat unneccesary needs_cudnn_workspace with #37 , but due to some reason always computing the neccesary workspace size via cudnn for bwd_data.

The current solution looks like this:

// let workspace_size_bwd_data = API::get_convolution_backward_data_workspace_size(*CUDNN.id_c(), useable_algo_bwd_data.as_cudnn().unwrap(), *filter_desc.id_c(), *conv_desc.id_c(), *src_desc.id_c(), *dest_desc.id_c()).unwrap();
let workspace_size_bwd_data = match try!(useable_algo_bwd_data.needs_cudnn_workspace()) {
false => 1,
true => API::get_convolution_backward_data_workspace_size(*CUDNN.id_c(), useable_algo_bwd_data.as_cudnn().unwrap(), *filter_desc.id_c(), *conv_desc.id_c(), *src_desc.id_c(), *dest_desc.id_c()).unwrap(),
};

but optimally we would want to get rid of our own needs_cudnn_workspace heuristics.

@hobofan
Copy link
Member Author

hobofan commented Mar 3, 2016

#40 introduced a fix for this and removed needs_cudnn_workspace.

However I had to introduce a workaround which is tracked #42.

@hobofan hobofan closed this as completed Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant