Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to reconnect to server if server dies #203

Closed
avojak opened this issue Dec 8, 2021 · 0 comments · Fixed by #204
Closed

Unable to reconnect to server if server dies #203

avojak opened this issue Dec 8, 2021 · 0 comments · Fixed by #204
Labels
bug Something isn't working

Comments

@avojak
Copy link
Owner

avojak commented Dec 8, 2021

If the server stops, the client is unable to re-connect without restarting. This is due to an edge case where the server connection is not unset from the connection manager.

Fix is on ServerConnectionManager.on_server_connection_closed () to check if open_connections has an entry, and if so, unset it.
@avojak avojak added the bug Something isn't working label Dec 8, 2021
@avojak avojak mentioned this issue Dec 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unset open connections in the signal handler avojak/iridium
1 participant
@avojak