Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-ecs: minHealthyPercent default value should match documented default in ecs service #14277

Closed
dgoetsch opened this issue Apr 20, 2021 · 1 comment
Closed

aws-ecs: minHealthyPercent default value should match documented default in ecs service #14277

dgoetsch opened this issue Apr 20, 2021 · 1 comment
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container breaking-change This issue requires a breaking change to remediate. bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2

Comments

@dgoetsch
Copy link
Contributor

Please see:

The default value of minHealthyPercent is 50. See in the source.

The documented default value is 100%.

The default value for a replica service for minimumHealthyPercent is 100%. The default minimumHealthyPercent value for a service using the DAEMON service schedule is 0% for the AWS CLI, the AWS SDKs, and the APIs and 50% for the AWS Management Console.

This discrepancy is a bit weird, perhaps we could simply leave the value undefined; set the default according to the rules in the documentation; or always set it to 100%.
@dgoetsch dgoetsch added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 20, 2021
@peterwoodworth peterwoodworth added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Apr 20, 2021
@SoManyHs SoManyHs added p2 breaking-change This issue requires a breaking change to remediate. and removed needs-triage This issue or PR still needs to be triaged. labels Apr 22, 2021
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Apr 23, 2022
@MarrickLip MarrickLip mentioned this issue Oct 9, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container breaking-change This issue requires a breaking change to remediate. bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@uttarasridhar @dgoetsch @MrArnoldPalmer @SoManyHs @peterwoodworth