-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-cdk-lib/aws-codepipeline-actions: TextDecoder is not defined (2.87 -> 2.93) #26913
Comments
Hi @jedkass , thanks for reaching out. I tried reproducing the issue with statement It seems more like a Node issue, could you tell if you are able to use TextDecoder` in your app? |
I'm seeing the same issue in my jest unit tests. 2.92.0 is fine, it came with 2.93.0.
|
@jedkass ,it would be helpful if you could share the code snippet to repro this issue. |
@oleksii-donoha in ran into the same issue with jest unit tests. I was using an older version of jest and ts-jest and after updating jest to 29.6.4 and ts-jest to 29.1.1 the reference error disappeared. Hope this helps. |
It does seem like updating to jest 29 solves the issue |
Ahh I didn't realize I didn't post this in the original issue description, but this exception was also cropping up for me in jest unit tests! Sounds like others have resolved this by updating that. Thanks @rehos and @oleksii-donoha! |
Today I was also seeing this issue in a GitHub Action for one of my CDK projects.
The GitHub action takes care of updating dependencies, but does not change the CDK version. This points also into the direction that the issue is unrelated to a CDK version upgrade. Following the previous comments I updated the version(s) related to Jest
and this resolves the issue for me. |
Yep, upgrading Jest fixed the same issue for me. In light of that, think this issue can probably be closed. |
good to hear 👍🏻 thanks for sharing the outcome |
|
Describe the bug
After upgrading
aws-cdk-lib
from2.87
to2.93
, when trying toimport { LambdaInvokeAction } from 'aws-cdk-lib/aws-codepipeline-actions';
, I get the following exception/stack trace:Expected Behavior
I think this should import with no issues, but not sure if I need to take any additional action on my end as part of this upgrade given the introduction of
TextDecoder
.Current Behavior
See above.
Reproduction Steps
I honestly don't have a trivial setup here where I can easily extract an SSCCE so this ticket might die. Apologies in advance. I can give an overview of my setup and maybe that + the stack trace can provide enough of a hint for your expertise.
import { LambdaInvokeAction } from 'aws-cdk-lib/aws-codepipeline-actions';
Possible Solution
I've seen old
TextDecoder
issues on the internet related to Node versions, but I'm on a pretty recent version of Node (18.15.0). This change seemed to introduce the line in question, so I'm guessing it's the source of the issue.Additional Information/Context
No response
CDK CLI Version
2.93.0
Framework Version
No response
Node.js Version
18.15.0
OS
alpine3.17 (node:18.15.0-alpine3.17 docker image)
Language
Typescript
Language Version
TypeScript 5.1.6
Other information
No response
The text was updated successfully, but these errors were encountered: