Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceMap Support #43

Open
m-rph opened this issue Dec 1, 2023 · 2 comments
Open

SourceMap Support #43

m-rph opened this issue Dec 1, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@m-rph
Copy link

m-rph commented Dec 1, 2023

Sourcemaps are currently not supported meaning that stack traces will be from transpiled JS sources. This is not ideal for debugging purposes.

The parcel bundler has implemented support for source maps in a rust package. Its not available on crates.io but the logic of deserializing a sourcemap is not very complicated.

https://github.com/parcel-bundler/source-map/tree/master/parcel_sourcemap

Here is explanation of sourcemaps:
https://www.bugsnag.com/blog/source-maps/

If this could be implemented without pulling in serde json dependency it would be ideal since the QuickJS engine already has a build in json parser

@richarddavison richarddavison added the enhancement New feature or request label Jan 24, 2024
@MisterJimson
Copy link

Can't sourcemaps be handled at the bundler level? What does llrt need to do?

@richarddavison
Copy link
Collaborator

Can't sourcemaps be handled at the bundler level? What does llrt need to do?

It can! It would just be convenient. But ideally, source maps should stay of the deployment artifacts in Lambda as they add size that needs to pulled in to the execution environment, which adds time. Users can get the original source by using offline approach instead like https://www.npmjs.com/package/source-map-cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants