Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent singular scale estimates under rotation #25

Open
axelpale opened this issue Jul 22, 2021 · 3 comments
Open

Prevent singular scale estimates under rotation #25

axelpale opened this issue Jul 22, 2021 · 3 comments

Comments

@axelpale
Copy link
Owner

Let the domain be [[-1,0],[1,0]] and the range [[0,-1],[0,1]]. The in other words the plane rotates 90 degrees.

Let us apply TS estimator. The estimate becomes { a: 0, b: 0, x: 1, y: 0 } which means that all points map to [1,0].

This is optimal behavior in a sense that it maps the domain as close to the range as possible. However, is this desired behavior? The singularity causes information loss. It maps the whole space to a point and therefore it is not anymore an affine transformation but an affine map. Should we promise that the estimates are always true affine transformations?

An approach that would satisfy the requirement is to fall back to translation if the linear transformation becomes singular. However, this causes a discontinuity at rotation angles near 90 degrees.

Another approach would always estimate a TSR and then extract the required part, TS.

@axelpale
Copy link
Owner Author

Maybe it is enough to document that S and TS are able to produce singular transformations.

@axelpale
Copy link
Owner Author

This might have something to do with robustness issues fixed in #31 and subsequent v2.0.1

@axelpale
Copy link
Owner Author

axelpale commented Nov 7, 2024

Maybe S and TS should determine scaling from the distances to the center points of the point sets. This way the scale estimate would be invariant to input rotation.

@axelpale axelpale changed the title Prevent singular estimates Prevent singular scale estimates under rotation Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant