Skip to content
This repository was archived by the owner on Aug 31, 2018. It is now read-only.

Commit 1cc05d9

Browse files
refackaddaleax
authored andcommitted
doc: add recommendations for first timers
PR-URL: nodejs/node#16350 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
1 parent c14a890 commit 1cc05d9

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

COLLABORATOR_GUIDE.md

+8-5
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,9 @@ understand the project governance model as outlined in
2424

2525
## Issues and Pull Requests
2626

27-
Courtesy should always be shown to individuals submitting issues and
28-
pull requests to the Node.js project.
27+
Courtesy should **always** be shown to individuals submitting issues and pull
28+
requests to the Node.js project. Be welcoming to first time contributors,
29+
identified by the GitHub ![badge](./doc/first_timer_badge.png) badge.
2930

3031
Collaborators should feel free to take full responsibility for
3132
managing issues and pull requests they feel qualified to handle, as
@@ -68,6 +69,9 @@ wide-reaching impact), and focused changes that affect only documentation
6869
and/or the test suite, may be landed after a shorter delay if they have
6970
multiple approvals.
7071

72+
For first time contributors, ask the author if they have configured their git
73+
username and email to their liking as per [this guide][git-username].
74+
7175
For non-breaking changes, if there is no disagreement amongst
7276
Collaborators, a pull request may be landed given appropriate review.
7377
Where there is discussion amongst Collaborators, consensus should be
@@ -362,10 +366,8 @@ The TSC should serve as the final arbiter where required.
362366
* If you do, please force-push removing the merge.
363367
* Reasons for not using the web interface button:
364368
* The merge method will add an unnecessary merge commit.
365-
* The rebase & merge method adds metadata to the commit title.
366-
* The rebase method changes the author.
367369
* The squash & merge method has been known to add metadata to the
368-
commit title.
370+
commit title (the PR #).
369371
* If more than one author has contributed to the PR, keep the most recent
370372
author when squashing.
371373

@@ -675,3 +677,4 @@ LTS working group and the Release team.
675677
[backporting guide]: doc/guides/backporting-to-release-lines.md
676678
[Stability Index]: doc/api/documentation.md#stability-index
677679
[Enhancement Proposal]: https://github.com/nodejs/node-eps
680+
[git-username]: https://help.github.com/articles/setting-your-username-in-git/

doc/first_timer_badge.png

1.5 KB
Loading

0 commit comments

Comments
 (0)