Skip to content
This repository was archived by the owner on Aug 31, 2018. It is now read-only.

Commit 28df95b

Browse files
komawaraddaleax
authored andcommittedDec 7, 2017
tools: rename unused variale in more pythonic way
The 'Main' function in tools/test.py file was using a variable named ``all_outcomes`` to store a value not being used. It is a best practice to name unused variables, often return values of functions/methods (as in this case) as ``_`` [1]. This just helps keep the code a bit cleaner and avoid any silly mistakes. PR-URL: nodejs/node#16171 Refs: [1] https://stackoverflow.com/a/5477153 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent ac9d415 commit 28df95b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎tools/test.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1678,7 +1678,7 @@ def Main():
16781678
}
16791679
test_list = root.ListTests([], path, context, arch, mode)
16801680
unclassified_tests += test_list
1681-
(cases, unused_rules, all_outcomes) = (
1681+
(cases, unused_rules, _) = (
16821682
config.ClassifyTests(test_list, env))
16831683
if globally_unused_rules is None:
16841684
globally_unused_rules = set(unused_rules)

0 commit comments

Comments
 (0)
This repository has been archived.