Skip to content
This repository was archived by the owner on Aug 31, 2018. It is now read-only.

Commit 54a921a

Browse files
bnoordhuisQard
authored andcommitted
src: remove superfluous HandleScope
Accessors implicitly run inside a HandleScope, UDPWrap::GetFD() doesn't need to create one explicitly. PR-URL: nodejs/node#16482 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 9438729 commit 54a921a

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/udp_wrap.cc

-1
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,6 @@ void UDPWrap::New(const FunctionCallbackInfo<Value>& args) {
169169
void UDPWrap::GetFD(Local<String>, const PropertyCallbackInfo<Value>& args) {
170170
int fd = UV_EBADF;
171171
#if !defined(_WIN32)
172-
HandleScope scope(args.GetIsolate());
173172
UDPWrap* wrap = Unwrap<UDPWrap>(args.Holder());
174173
if (wrap != nullptr)
175174
uv_fileno(reinterpret_cast<uv_handle_t*>(&wrap->handle_), &fd);

0 commit comments

Comments
 (0)