Skip to content
This repository was archived by the owner on Aug 31, 2018. It is now read-only.

Commit 996cedd

Browse files
joyeecheungQard
authored andcommitted
build: run linter before running tests
PR-URL: nodejs/node#16284 Fixes: https://github.com/node/issues/16283 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
1 parent 575f9f0 commit 996cedd

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

Makefile

+13-1
Original file line numberDiff line numberDiff line change
@@ -216,15 +216,26 @@ test: all
216216
$(MAKE) build-addons
217217
$(MAKE) build-addons-napi
218218
$(MAKE) doc-only
219+
$(MAKE) lint
219220
$(MAKE) cctest
220221
$(PYTHON) tools/test.py --mode=release -J \
221222
$(CI_ASYNC_HOOKS) \
222223
$(CI_JS_SUITES) \
223224
$(CI_NATIVE_SUITES) \
224225
doctool known_issues
225-
$(MAKE) lint
226226
endif
227227

228+
# For a quick test, does not run linter or build doc
229+
test-only: all
230+
$(MAKE) build-addons
231+
$(MAKE) build-addons-napi
232+
$(MAKE) cctest
233+
$(PYTHON) tools/test.py --mode=release -J \
234+
$(CI_ASYNC_HOOKS) \
235+
$(CI_JS_SUITES) \
236+
$(CI_NATIVE_SUITES) \
237+
known_issues
238+
228239
test-cov: all
229240
$(MAKE) build-addons
230241
$(MAKE) build-addons-napi
@@ -1110,6 +1121,7 @@ endif
11101121
test-gc \
11111122
test-gc-clean \
11121123
test-hash-seed \
1124+
test-only \
11131125
test-v8 \
11141126
test-v8-all \
11151127
test-v8-benchmarks \

0 commit comments

Comments
 (0)