fix: do not sort enums with implicit values

azat-io · Jun 9, 2023 · 166edac · 166edac
1 parent a5a0582
commit 166edac
Show file tree

Hide file tree

Showing 2 changed files with 76 additions and 1 deletion.
diff --git a/rules/sort-enums.ts b/rules/sort-enums.ts
@@ -69,7 +69,10 @@ export default createEslintRule<Options, MESSAGE_ID>({
   ],
   create: context => ({
     TSEnumDeclaration: node => {
-      if (node.members.length > 1) {
+      if (
+        node.members.length > 1 &&
+        node.members.some(({ initializer }) => initializer)
+      ) {
         let options = complete(context.options.at(0), {
           type: SortType.alphabetical,
           order: SortOrder.asc,

diff --git a/test/sort-enums.test.ts b/test/sort-enums.test.ts
@@ -284,6 +284,30 @@ describe(RULE_NAME, () => {
         ],
       })
     })
+
+    it(`${RULE_NAME}(${type}): does not sort enums with implicit values`, () => {
+      ruleTester.run(RULE_NAME, rule, {
+        valid: [
+          {
+            code: dedent`
+              export enum KessokuBand {
+                HitoriGotou, // implicit value: 0
+                NijikaIjichi, // implicit value: 1
+                RyouYamada, // implicit value: 2
+                IkuyoKita, // implicit value: 3
+              }
+            `,
+            options: [
+              {
+                type: SortType.alphabetical,
+                order: SortOrder.asc,
+              },
+            ],
+          },
+        ],
+        invalid: [],
+      })
+    })
   })
 
   describe(`${RULE_NAME}: sorting by natural order`, () => {
@@ -560,6 +584,30 @@ describe(RULE_NAME, () => {
         ],
       })
     })
+
+    it(`${RULE_NAME}(${type}): does not sort enums with implicit values`, () => {
+      ruleTester.run(RULE_NAME, rule, {
+        valid: [
+          {
+            code: dedent`
+              export enum KessokuBand {
+                HitoriGotou, // implicit value: 0
+                NijikaIjichi, // implicit value: 1
+                RyouYamada, // implicit value: 2
+                IkuyoKita, // implicit value: 3
+              }
+            `,
+            options: [
+              {
+                type: SortType.natural,
+                order: SortOrder.asc,
+              },
+            ],
+          },
+        ],
+        invalid: [],
+      })
+    })
   })
 
   describe(`${RULE_NAME}: sorting by line length`, () => {
@@ -850,6 +898,30 @@ describe(RULE_NAME, () => {
         ],
       })
     })
+
+    it(`${RULE_NAME}(${type}): does not sort enums with implicit values`, () => {
+      ruleTester.run(RULE_NAME, rule, {
+        valid: [
+          {
+            code: dedent`
+              export enum KessokuBand {
+                HitoriGotou, // implicit value: 0
+                NijikaIjichi, // implicit value: 1
+                RyouYamada, // implicit value: 2
+                IkuyoKita, // implicit value: 3
+              }
+            `,
+            options: [
+              {
+                type: SortType['line-length'],
+                order: SortOrder.desc,
+              },
+            ],
+          },
+        ],
+        invalid: [],
+      })
+    })
   })
 
   describe(`${RULE_NAME}: misc`, () => {