fix(sort-imports): fix explicit fallback sort overriding side-effects

azat-io · Mar 9, 2025 · 1ac83c9 · 1ac83c9
1 parent 8d4ad4f
commit 1ac83c9
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/test/rules/sort-imports.test.ts b/test/rules/sort-imports.test.ts
@@ -1829,6 +1829,31 @@ describe(ruleName, () => {
           valid: [],
         },
       )
+
+      ruleTester.run(
+        `${ruleName}(${type}): does not sort side-effects and side-effect-style even with fallback sort`,
+        rule,
+        {
+          valid: [
+            {
+              options: [
+                {
+                  groups: ['side-effect', 'side-effect-style'],
+                  fallbackSort: { type: 'alphabetical' },
+                },
+              ],
+              code: dedent`
+                import 'b';
+                import 'a';
+
+                import 'b.css';
+                import 'a.css';
+              `,
+            },
+          ],
+          invalid: [],
+        },
+      )
     })
 
     ruleTester.run(

diff --git a/utils/compare.ts b/utils/compare.ts
@@ -30,6 +30,10 @@ export let compare = <T extends SortingNode>({
   a,
   b,
 }: CompareParameters<T>): number => {
+  if (options.type === 'unsorted') {
+    return 0
+  }
+
   let finalNodeValueGetter = nodeValueGetter ?? ((node: T) => node.name)
   let compareValue = computeCompareValue({
     nodeValueGetter: finalNodeValueGetter,