feat: support bun builtin modules in sort-imports rule

azat-io · Sep 12, 2023 · 37bca14 · 37bca14
1 parent 37512c9
commit 37bca14
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 3 deletions.
diff --git a/rules/sort-imports.ts b/rules/sort-imports.ts
@@ -199,10 +199,24 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({
           }),
         )
 
-      let isCoreModule = (value: string) =>
-        builtinModules.includes(
-          value.startsWith('node:') ? value.split('node:')[1] : value,
+      let isCoreModule = (value: string) => {
+        let bunModules = [
+          'bun',
+          'bun:ffi',
+          'bun:jsc',
+          'bun:sqlite',
+          'bun:test',
+          'bun:wrap',
+          'detect-libc',
+          'undici',
+          'ws',
+        ]
+        return (
+          builtinModules.includes(
+            value.startsWith('node:') ? value.split('node:')[1] : value,
+          ) || bunModules.includes(value)
         )
+      }
 
       if (node.importKind === 'type') {
         if (node.type === 'ImportDeclaration') {

diff --git a/test/sort-imports.test.ts b/test/sort-imports.test.ts
@@ -3558,6 +3558,7 @@ describe(RULE_NAME, () => {
         valid: [
           {
             code: dedent`
+              import { expect, test } from 'bun:test'
               import { writeFile } from 'node:fs/promises'
 
               import { useEffect } from 'react'
@@ -3574,8 +3575,10 @@ describe(RULE_NAME, () => {
             code: dedent`
               import { writeFile } from 'node:fs/promises'
               import { useEffect } from 'react'
+              import { expect, test } from 'bun:test'
             `,
             output: dedent`
+              import { expect, test } from 'bun:test'
               import { writeFile } from 'node:fs/promises'
 
               import { useEffect } from 'react'
@@ -3593,6 +3596,13 @@ describe(RULE_NAME, () => {
                   right: 'react',
                 },
               },
+              {
+                messageId: 'unexpectedImportsOrder',
+                data: {
+                  left: 'react',
+                  right: 'bun:test',
+                },
+              },
             ],
           },
         ],