Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic derives for the Sonyflake struct #26

Open
caniko opened this issue Mar 5, 2025 · 1 comment
Open

Basic derives for the Sonyflake struct #26

caniko opened this issue Mar 5, 2025 · 1 comment

Comments

@caniko
Copy link

caniko commented Mar 5, 2025

#[derive(Clone, Copy PartialEq, Eq, Hash)]
    pub struct Id(pub Id);

States that Sonyflake doesn't implement Copy, Eq or Hash, upon inspecting the code it is true. You don't derive these, can you please do it?

@bahlo
Copy link
Owner

bahlo commented Mar 7, 2025

Hi @caniko, I see no reason not to derive these. Feel free to open a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants