Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: beberlei/assert
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.3.2
Choose a base ref
...
head repository: beberlei/assert
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.3.3
Choose a head ref
  • 7 commits
  • 11 files changed
  • 5 contributors

Commits on Sep 27, 2022

  1. Allow any value to be passed to Assertion::isCountable() (#303) 

    * Allow any value to be passed to Assertion::isCountable()

Static analysis tools complain about type of `$value` argument but in fact it could be of any type since it will be checked later (that's the purpose of the method).

* Revert unwanted changes

Github's web IDE did something weird I think, I did not change those line on purpose (obviously).
    @Wirone
    Wirone authored Sep 27, 2022
    1

    Verified

    This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    e74044d View commit details

Commits on Feb 25, 2023

  1. Update ci.yml (#332)

    @rogervila
    rogervila authored Feb 25, 2023
    1

    Verified

    This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    6031341 View commit details

Commits on Mar 19, 2024

  1. Fix typo in CONTRIBUTING.md (#327)

    @TimWolla
    TimWolla authored Mar 19, 2024
    Loading
    Loading status checks…

    Verified

    This commit was created on github.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    be26899 View commit details

  2. Add .github/ export-ignore to .gitattributes (#326)

    @TimWolla
    TimWolla authored Mar 19, 2024
    Loading
    Loading status checks…

    Verified

    This commit was created on github.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    cc6400b View commit details

Commits on Apr 23, 2024

  1. Bump minimum PHP requirement to PHP 7.1 (#338) 

    PR #337 depends on this.

Bumps the minimum required PHP version to PHP 7.1 to use explicit nullable parameter type syntax.
    @Ayesh
    Ayesh authored Apr 23, 2024
    Loading
    Loading status checks…

    Verified

    This commit was created on github.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    9eb17b7 View commit details

  2. [PHP 8.4] Fixes for implicit nullability deprecation (#337) 

    Fixes all issues that emit deprecation notices on PHP 8.4 for implicit nullable parameter type declarations.

See:
 - [RFC](https://wiki.php.net/rfc/deprecate-implicitly-nullable-types)
 - [PHP 8.4: Implicitly nullable parameter declarations deprecated](https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated)
    @Ayesh
    Ayesh authored Apr 23, 2024
    Loading
    Loading status checks…

    Verified

    This commit was created on github.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    78aa6be View commit details

Commits on Jul 15, 2024

  1. Add PHP 8.4 to CI (#341)

    @TimWolla
    TimWolla authored Jul 15, 2024
    Loading
    Loading status checks…

    Verified

    This commit was created on github.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    b5fd8ea View commit details
1 change: 1 addition & 0 deletions .gitattributes
View file
Original file line number Diff line number Diff line change
@@ -3,6 +3,7 @@

.editorconfig export-ignore
.gitattributes export-ignore
.github/ export-ignore
.gitignore export-ignore
.php_cs export-ignore
.travis/ export-ignore
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: ['7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1']
php-versions: ['7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4']

steps:
- name: Checkout
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# How to contribute

Thanks for contributing to assert! Just follow these single guidelines:
Thanks for contributing to assert! Just follow these simple guidelines:

- You must use [feature / topic branches](https://git-scm.com/book/en/v2/Git-Branching-Branching-Workflows) to ease the merge of contributions.
- Coding standard compliance must be ensured before committing or opening pull requests by running `composer assert:cs-fix` or `composer assert:cs-lint` in the root directory of this repository.
2 changes: 1 addition & 1 deletion composer.json
View file
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
"sort-packages": true
},
"require": {
"php": "^7.0 || ^8.0",
"php": "^7.1 || ^8.0",
"ext-simplexml": "*",
"ext-mbstring": "*",
"ext-ctype": "*",
6 changes: 3 additions & 3 deletions lib/Assert/Assert.php
View file
Original file line number Diff line number Diff line change
@@ -42,7 +42,7 @@ abstract class Assert
* The assertion chain can be stateful, that means be careful when you reuse
* it. You should never pass around the chain.
*/
public static function that($value, $defaultMessage = null, string $defaultPropertyPath = null): AssertionChain
public static function that($value, $defaultMessage = null, ?string $defaultPropertyPath = null): AssertionChain
{
$assertionChain = new AssertionChain($value, $defaultMessage, $defaultPropertyPath);

@@ -55,7 +55,7 @@ public static function that($value, $defaultMessage = null, string $defaultPrope
* @param mixed $values
* @param string|callable|null $defaultMessage
*/
public static function thatAll($values, $defaultMessage = null, string $defaultPropertyPath = null): AssertionChain
public static function thatAll($values, $defaultMessage = null, ?string $defaultPropertyPath = null): AssertionChain
{
return static::that($values, $defaultMessage, $defaultPropertyPath)->all();
}
@@ -66,7 +66,7 @@ public static function thatAll($values, $defaultMessage = null, string $defaultP
* @param mixed $value
* @param string|callable|null $defaultMessage
*/
public static function thatNullOr($value, $defaultMessage = null, string $defaultPropertyPath = null): AssertionChain
public static function thatNullOr($value, $defaultMessage = null, ?string $defaultPropertyPath = null): AssertionChain
{
return static::that($value, $defaultMessage, $defaultPropertyPath)->nullOr();
}
Loading