Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying corpus sometimes fails #324

Closed
jerneju opened this issue Nov 8, 2017 · 3 comments
Closed

Copying corpus sometimes fails #324

jerneju opened this issue Nov 8, 2017 · 3 comments
Assignees

Comments

@jerneju
Copy link
Contributor

jerneju commented Nov 8, 2017

Text version

Current (~0.2.5) and older

Orange version

master

Expected behavior
corpus = Corpus(...)
new_corpus = corpus.copy()

That should work and not raise an error.

Actual behavior

orangecontrib.text.corpus in set_text_features at line 90
raise ValueError('Feature "{}" not found.'.format(f))
orangecontrib.text.corpus in init at line 73
self.set_text_features(text_features)
orangecontrib.text.corpus in copy at line 321
self.W.copy(), copy(self.text_features))
orangecontrib.text.widgets.owpreprocess in set_data at line 598
self.corpus = data.copy() if data is not None else None

https://sentry.io/biolab/orange3-text-bl/issues/399242697/

Steps to reproduce the behavior
Additional info (worksheets, data, screenshots, ...)
@jerneju
Copy link
Contributor Author

jerneju commented Nov 8, 2017

data.transform(new_domain) does not update text_features.

@jerneju jerneju self-assigned this Nov 8, 2017
@nikicc
Copy link
Contributor

nikicc commented Nov 8, 2017

Could you fix transform on Corpus to retain them?

@jerneju
Copy link
Contributor Author

jerneju commented Nov 8, 2017

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants