Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validate_email #440

Closed
PrimozGodec opened this issue Jun 19, 2019 · 0 comments · Fixed by #442
Closed

Remove validate_email #440

PrimozGodec opened this issue Jun 19, 2019 · 0 comments · Fixed by #442

Comments

@PrimozGodec
Copy link
Collaborator

Dependency validate_email is old and not maintained. It is used in pubmed.py and I think it is not required. Those two lines can be just omitted:

if not validate_email(email):
raise ValueError('{} is not a valid email address.'.format(email))

We should consider removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant