Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve try_get_chain_position the logic #1691

Closed
notmandatory opened this issue Nov 13, 2024 · 2 comments
Closed

Improve try_get_chain_position the logic #1691

notmandatory opened this issue Nov 13, 2024 · 2 comments
Labels
audit Suggested as result of external code audit module-blockchain
Milestone

Comments

@notmandatory
Copy link
Member

notmandatory commented Nov 13, 2024

"In try_get_chain_position the logic to filter out confirmed ancestors was copy-pasted for the descendants (you can see as the comment wasn't updated, it still mentions "We're filtering the ancestors"). But if a confirmed descendant is encountered it means the transaction is confirmed too, so it could shortcut?"

@notmandatory notmandatory converted this from a draft issue Nov 13, 2024
@notmandatory notmandatory added audit Suggested as result of external code audit module-blockchain labels Nov 13, 2024
@notmandatory notmandatory moved this to Discussion in BDK Wallet Nov 13, 2024
@oleonardolima
Copy link
Contributor

It can be closed now, as #1670 has been merged, right ?

@notmandatory
Copy link
Member Author

Yes you're right, the try_get_chain_position function was removed in #1670 so we can close this one now too.

@github-project-automation github-project-automation bot moved this from Discussion to Done in BDK Wallet Dec 13, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit Suggested as result of external code audit module-blockchain
Projects
Archived in project
Development

No branches or pull requests

2 participants