Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "spender" and "to" from "submit" #11

Closed
mootz12 opened this issue Dec 9, 2024 · 1 comment
Closed

Remove "spender" and "to" from "submit" #11

mootz12 opened this issue Dec 9, 2024 · 1 comment
Labels
enhancement New feature or request pool This issue impacts the pool wontfix This will not be worked on

Comments

@mootz12
Copy link
Contributor

mootz12 commented Dec 9, 2024

Having a single "spender" and "to" for a vector of requests is too restricting.

For each action, the user acted against should be able to be specified.

For actions where tokens are being input into the protocol, the "user" would be the spender, and would need to authorize the transactions.

For actions where tokens are being sent out of the protocol, the "user" would be to, and would not need to authorize the transactions.

Technical Notes

This might cause some confusion when designing the Request object for use with filling liquidations.

@mootz12 mootz12 added enhancement New feature or request pool This issue impacts the pool labels Dec 9, 2024
This was referenced Dec 9, 2024
@mootz12
Copy link
Contributor Author

mootz12 commented Dec 30, 2024

This change is being dropped from Blend v2. It's primary use case was to enable flash loans, and it was decided that flash loans will be a better fit as separate function.

Secondly, there isn't much benefit for other request types to make this change, and it ends up making the implementation and interface more confusing.

@mootz12 mootz12 closed this as completed Dec 30, 2024
@mootz12 mootz12 added the wontfix This will not be worked on label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pool This issue impacts the pool wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant