Skip to content

Commit 0b2328f

Browse files
mengdilinfacebook-github-bot
authored andcommitted
Turn on blocking build for AVX512 and SVE on GHA (facebookresearch#3717)
Summary: Pull Request resolved: facebookresearch#3717 they have been running in shadow mode for quite some time now. I spot-checked the builds for the past 10 jobs and they all look good. Since `continue-on-error` will always mark a job as "green" even if it fails, I need a way to holistically verify these builds actually work reliably. Turning the builds to blocking to accomplish that. Reviewed By: ramilbakhshyiev Differential Revision: D60692521 fbshipit-source-id: 172a6362c672b0376c76559f12852110936756df
1 parent a757309 commit 0b2328f

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

.github/workflows/build.yml

-6
Original file line numberDiff line numberDiff line change
@@ -56,17 +56,14 @@ jobs:
5656
opt_level: avx2
5757
linux-x86_64-AVX512-cmake:
5858
name: Linux x86_64 AVX512 (cmake)
59-
continue-on-error: true # non-blocking mode for now
6059
needs: linux-x86_64-cmake
6160
runs-on: faiss-aws-m7i.large
6261
steps:
6362
- name: Checkout
64-
continue-on-error: true # non-blocking mode for now
6563
uses: actions/checkout@v4
6664
- uses: ./.github/actions/build_cmake
6765
with:
6866
opt_level: avx512
69-
continue-on-error: true # non-blocking mode for now
7067
linux-x86_64-GPU-cmake:
7168
name: Linux x86_64 GPU (cmake)
7269
needs: linux-x86_64-cmake
@@ -103,13 +100,10 @@ jobs:
103100
name: Linux arm64 SVE (cmake)
104101
needs: linux-x86_64-cmake
105102
runs-on: faiss-aws-r8g.large
106-
continue-on-error: true # non-blocking mode for now
107103
steps:
108104
- name: Checkout
109-
continue-on-error: true # non-blocking mode for now
110105
uses: actions/checkout@v4
111106
- uses: ./.github/actions/build_cmake
112-
continue-on-error: true # non-blocking mode for now
113107
with:
114108
opt_level: sve
115109
linux-x86_64-conda:

0 commit comments

Comments
 (0)