Skip to content

Commit fd6d784

Browse files
Michael Norrisfacebook-github-bot
Michael Norris
authored andcommitted
Resolve "incorrect-portions-license" errors: add no license lint to top of GPU files with both licenses (facebookresearch#3965)
Summary: Pull Request resolved: facebookresearch#3965 End goal: add some lint to prevent files landing without any header. This creates churn for the oncall. Example is the last diff in this stack: D64488600 This is the first diff in enabling linting. I wanted the diff which updates all files to be just the automated command and the .toml config files changes, so this diff is a preparation step. This particular diff solves: we get errors due to having both NVidia and FB license comment headers in the same files. See the errors in D64429711 under "linter-coverage-verification" signal. Context on linting: https://fb.workplace.com/groups/lintqa/posts/3762373340693743/?comment_id=3762915930639484&reply_comment_id=3763044163959994 Per OSS, we cannot remove the Nvidia notice: https://fb.workplace.com/groups/osssupport/posts/27179779734977284/?comment_id=27181801724775085&reply_comment_id=27181818148106776 So, we add the lint ignore here. Reviewed By: asadoughi Differential Revision: D64481766 fbshipit-source-id: 0468104a095831cac7dd5bf3c519cfb5a2ee1575
1 parent f9a01c6 commit fd6d784

26 files changed

+28
-2
lines changed

CMakeLists.txt

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# @lint-ignore-every LICENSELINT
12
# Copyright (c) Facebook, Inc. and its affiliates.
23
# All rights reserved.
34
#

cmake/FindMKL.cmake

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
# Copyright (c) Facebook, Inc. and its affiliates.
1+
# @lint-ignore-every LICENSELINT
2+
# Copyright (c) Meta Platforms, Inc. and affiliates.
23
# All rights reserved.
34
#
45
# This source code is licensed under the BSD-style license found in the

cmake/link_to_faiss_lib.cmake

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
# Copyright (c) Facebook, Inc. and its affiliates.
1+
# @lint-ignore-every LICENSELINT
2+
# Copyright (c) Meta Platforms, Inc. and affiliates.
23
# All rights reserved.
34
#
45
# This source code is licensed under the BSD-style license found in the

faiss/gpu/GpuDistance.cu

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/GpuIndex.h

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/GpuIndexCagra.cu

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/GpuIndexCagra.h

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/GpuResources.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/GpuResources.h

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/StandardGpuResources.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/StandardGpuResources.h

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/impl/FlatIndex.cu

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/impl/FlatIndex.cuh

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/impl/RaftCagra.cu

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/impl/RaftCagra.cuh

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/impl/RaftFlatIndex.cu

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/impl/RaftFlatIndex.cuh

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/impl/RaftIVFFlat.cu

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/impl/RaftIVFFlat.cuh

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/impl/RaftIVFPQ.cu

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/impl/RaftIVFPQ.cuh

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/test/TestGpuDistance.cu

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/test/TestGpuIndexCagra.cu

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/test/TestGpuIndexIVFFlat.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/utils/RaftUtils.cu

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/utils/RaftUtils.h

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

0 commit comments

Comments
 (0)