Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support net8.0 framework #145

Closed
Orbling opened this issue Aug 8, 2024 · 6 comments
Closed

Support net8.0 framework #145

Orbling opened this issue Aug 8, 2024 · 6 comments

Comments

@Orbling
Copy link

Orbling commented Aug 8, 2024

Is your feature request related to a problem?
.Net 7 is now past EOL and this library is still well used by the community, upgrading a project to .Net 8, this library was unsupported and that's a problem.

Describe the feature you would like
Add net8.0 to target frameworks, I do not know of any reason it would no longer work or need any extensive modification.

Additional context
n/a

@blowdart
Copy link
Owner

blowdart commented Aug 8, 2024

You don't need a specific .NET version, the package as is works just fine (as there have been no api changes to auth handlers for an absolute age).

Are you actually getting any errors?

@Orbling
Copy link
Author

Orbling commented Aug 9, 2024

I had expected it to work as-is, as, as you say, there were no major changes that effected it. NuGet just seemed to report it as missing, presumably as the framework was not a specified target. I only use the Basic auth module for very low security dev site walls from the general public, but it's been very useful for that. I've observed your amending commits, thank you for getting on this so blisteringly quickly, highly appreciated! I'm not well acquainted with the NuGet system, but it has starting working since you have made those commits, as I tested it again just now. Though I would've thought it worked off the releases rather than the active repository and you've not yet made a new release, so I have no idea what changed, as it was entirely obstinate last night. Nevertheless your changes coming through look like sensible alterations for the interim changes to the framework, so are much appreciated.

@blowdart
Copy link
Owner

blowdart commented Aug 9, 2024

How annoyingly weird. I was going to ask you to give the new build a test, thank you for beating me to it! It's been a while since I built this via CI, let alone signed it, so I'll try to get it going within the next couple of days (I have a bunch of stuff I have booked this weekend).

@blowdart
Copy link
Owner

blowdart commented Aug 9, 2024

Fixed by 9d9773a

@blowdart blowdart closed this as completed Aug 9, 2024
@blowdart
Copy link
Owner

blowdart commented Aug 9, 2024

All done, and public on nuget now as v2.4.0

@Orbling
Copy link
Author

Orbling commented Aug 13, 2024

Many thanks, sorry was away for the weekend - I very much appreciate your work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants