Skip to content

Commit a896f14

Browse files
richardlaubmeck
authored andcommitted
src: remove base64 from process.versions
The `base64` dependency was previously removed along with the update script (`tools/dep_updaters/update-base64.sh`) but the generated header, `src/base64_version.h` was left behind and `process.versions` was still listing the last version of `base64` that was included in Node.js before it was removed Refs: nodejs#52714 PR-URL: nodejs#53442 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
1 parent 25fbd38 commit a896f14

File tree

4 files changed

+1
-11
lines changed

4 files changed

+1
-11
lines changed

src/base64_version.h

-6
This file was deleted.

src/node_metadata.cc

-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
#include "acorn_version.h"
33
#include "ada.h"
44
#include "ares.h"
5-
#include "base64_version.h"
65
#include "brotli/encode.h"
76
#include "cjs_module_lexer_version.h"
87
#include "llhttp.h"
@@ -113,7 +112,6 @@ Metadata::Versions::Versions() {
113112

114113
acorn = ACORN_VERSION;
115114
cjs_module_lexer = CJS_MODULE_LEXER_VERSION;
116-
base64 = BASE64_VERSION;
117115
uvwasi = UVWASI_VERSION_STRING;
118116

119117
#if HAVE_OPENSSL

src/node_metadata.h

+1-2
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,7 @@ namespace node {
5151
V(sqlite) \
5252
V(ada) \
5353
NODE_VERSIONS_KEY_UNDICI(V) \
54-
V(cjs_module_lexer) \
55-
V(base64)
54+
V(cjs_module_lexer)
5655

5756
#if HAVE_OPENSSL
5857
#define NODE_VERSIONS_KEY_CRYPTO(V) V(openssl)

test/parallel/test-process-versions.js

-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ const expected_keys = [
2323
'sqlite',
2424
'ada',
2525
'cjs_module_lexer',
26-
'base64',
2726
];
2827

2928
const hasUndici = process.config.variables.node_builtin_shareable_builtins.includes('deps/undici/undici.js');

0 commit comments

Comments
 (0)