Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: bnoordhuis/io.js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fix27856
Choose a head ref
Can’t automatically merge. Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jun 6, 2019

  1. test: set LC_ALL to known good value 

    Set the locale to a known good value because it affects ICU's date
string formatting. Setting LC_ALL needs to happen before the first
call to `icu::Locale::getDefault()` because ICU caches the result.

Fixes: #27856
    @bnoordhuis
    bnoordhuis committed Jun 6, 2019
    Copy the full SHA
    5de9358 View commit details
Showing with 5 additions and 0 deletions.
  1. +5 −0 test/parallel/test-process-env-tz.js
5 changes: 5 additions & 0 deletions test/parallel/test-process-env-tz.js
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
'use strict';

// Set the locale to a known good value because it affects ICU's date string
// formatting. Setting LC_ALL needs to happen before the first call to
// `icu::Locale::getDefault()` because ICU caches the result.
process.env.LC_ALL = 'C';

const common = require('../common');
const assert = require('assert');