Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: bnoordhuis/io.js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: promiseresolve
Choose a head ref
Can’t automatically merge. Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Sep 3, 2019

  1. doc: async_hooks.createHook promiseResolve option 

    Document the `promiseResolve` option to `async_hooks.createHook()`.

This seems to have been overlooked in commit b605b15 ("async_hooks:
support promise resolve hook") from September 2017.

It is documented elsewhere in the async_hooks API documentation, except
where you actually pass it in.
    @bnoordhuis
    bnoordhuis committed Sep 3, 2019
    Copy the full SHA
    94a75ee View commit details
Showing with 2 additions and 0 deletions.
  1. +2 −0 doc/api/async_hooks.md
2 changes: 2 additions & 0 deletions doc/api/async_hooks.md
View file
Original file line number Diff line number Diff line change
@@ -89,6 +89,7 @@ added: v8.1.0
* `before` {Function} The [`before` callback][].
* `after` {Function} The [`after` callback][].
* `destroy` {Function} The [`destroy` callback][].
* `promiseResolve` {Function} The [`promiseResolve` callback][].
* Returns: {AsyncHook} Instance used for disabling and enabling hooks

Registers functions to be called for different lifetime events of each async
@@ -685,6 +686,7 @@ never be called.
[`before` callback]: #async_hooks_before_asyncid
[`destroy` callback]: #async_hooks_destroy_asyncid
[`init` callback]: #async_hooks_init_asyncid_type_triggerasyncid_resource
[`promiseResolve` callback]: #async_hooks_promiseresolve_asyncid
[Hook Callbacks]: #async_hooks_hook_callbacks
[PromiseHooks]: https://docs.google.com/document/d/1rda3yKGHimKIhg5YeoAmCOtyURgsbTH_qaYR79FELlk/edit
[`Worker`]: worker_threads.html#worker_threads_class_worker