Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The context menu for visualizer mappings should use "Select Visualizer" rather than "Show Visualizer" #1791

Open
PathogenDavid opened this issue May 11, 2024 · 2 comments
Labels
proposal Request for a new feature
Milestone

Comments

@PathogenDavid
Copy link
Member

This is something that came up when Gonçalo and I were discussing #1769

Rather than showing a visualizer directly, this submenu selects which visualizer is used by the mapping. The wording should be changed to reflect this.

image

Additionally changing this dropdown doesn't seem to be honored when the workflow is running (or maybe only when a data mashup is involved? -- should check) we should perhaps make it read-only to make this clearer.

@glopesdev glopesdev added the proposal Request for a new feature label May 11, 2024
@glopesdev glopesdev added this to the 2.9 milestone Aug 2, 2024
@glopesdev
Copy link
Member

glopesdev commented Mar 5, 2025

@PathogenDavid Now that we fixed the behavior of #1841, I am slightly less inclined to go for this solution. Specifically, the bug with changing the context menu at runtime was fixed, and also clicking on the selected option will now always show/activate the visualizer (even if the selected option is already selected but the visualizer is closed).

Finally, the meaning of "Show" is valid even when the workflow is not running, as all visualizers marked to show will be immediately shown at workflow start time.

@glopesdev
Copy link
Member

glopesdev commented Mar 10, 2025

Could consider changing just for VisualizerMapping too and possibly also for the new ShowVisualizer node in #2137.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants