Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review all potential panics in the entire codebase. #432

Open
boocmp opened this issue Feb 12, 2025 · 2 comments
Open

Review all potential panics in the entire codebase. #432

boocmp opened this issue Feb 12, 2025 · 2 comments
Labels
good first issue Good for newcomers

Comments

@boocmp
Copy link
Collaborator

boocmp commented Feb 12, 2025

Review all potential panics.
Rewrite the code to return errors wherever it makes sense.
Comment on all cases where the panicking code is safe and explain why.

Cases:

  1. expect or unwrap called in function returning a Result
@ShivanKaul ShivanKaul added the good first issue Good for newcomers label Feb 13, 2025
@bridiver
Copy link

I think this should follow the same rules as https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/checks.md
where panic would be equivalent to CHECK

we can also expose DumpWithoutCrashing to rust

@boocmp
Copy link
Collaborator Author

boocmp commented Feb 25, 2025

Sounds like a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants