Copy proper app icon to /chrome/app/theme/mac/app.icns

With this, we can avoid patching chrome/BUILD.gn for this.

Author: simonhong

lib/util.js

@@ -93,6 +93,17 @@ const util = {
     fs.copySync(path.join(braveComponentsDir, 'resources', 'default_200_percent', 'brave'), path.join(chromeComponentsDir, 'resources', 'default_200_percent', 'chromium'))
     fs.copySync(path.join(braveAppVectorIconsDir, 'vector_icons', 'brave'), path.join(chromeAppDir, 'vector_icons', 'brave'))
     fs.copySync(path.join(braveResourcesDir, 'settings', 'brave_page_visibility.js'), path.join(chromeResourcesDir, 'settings', 'brave_page_visibility.js'))
+
+    if (process.platform === 'darwin') {
+      // Copy proper mac app icon for channel to chrome/app/theme/mac/app.icns.
+      // Each channel's app icons are stored in brave/app/theme/$channel/app.icns.
+      // With this copying, we don't need to modify chrome/BUILD.gn for this.
+      let channel = config.channel
+      if (config.debugBuild)
+        channel = 'development'
+      const source_icon_path = path.join(braveAppDir, 'theme', 'brave', 'mac', channel, 'app.icns')
+      fs.copySync(source_icon_path, path.join(chromeAppDir, 'theme', 'brave', 'mac', 'app.icns'))
+    }
   },
 
   // Chromium compares pre-installed midl files and generated midl files from IDL during the build to check integrity.