Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Insecure icon displayed for https upgrades #10338

Open
GeetaSarvadnya opened this issue Jun 17, 2020 · 3 comments
Open

[Android] Insecure icon displayed for https upgrades #10338

GeetaSarvadnya opened this issue Jun 17, 2020 · 3 comments
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes regression

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 17, 2020

Description

Insecure icon shown on https pages

Steps to reproduce

  1. Clean profile 1.10.92
  2. Visit http://https-everywhere.badssl.com/
  3. The lock icon is not shown in the URL bar

Note: Regular sites and YT works as expected. The secure icon is shown in the URL bar.

Actual result

1.10.92
image (2)

1.9.80
image

Expected result

Lock icon should be shown

Issue reproduces how often

Always

Issue happens on

  • Current Play Store version? No
  • Beta build? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Samsung Galaxy J3
  • Android version: 5.1.1

Brave version

1.10.92

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @brave/legacy_qa @SergeyZhukovsky @deeppandya @anthonypkeane
Reproduced the issue in the tablet by @btlechowski

@GeetaSarvadnya GeetaSarvadnya added QA/Yes QA/Test-Plan-Specified regression OS/Android Fixes related to Android browser functionality labels Jun 17, 2020
@GeetaSarvadnya GeetaSarvadnya added this to the 1.10.x - Release milestone Jun 17, 2020
@GeetaSarvadnya GeetaSarvadnya changed the title [Android] Incorrect icon is shown in the URL bar for http://https-everywhere.badssl.com/ [Android] Insecure icon shown on https pages Jun 17, 2020
@bsclifton
Copy link
Member

I believe this is the same issue we see on desktop:
#10190

@jumde
Copy link
Contributor

jumde commented Jun 17, 2020

Mixed content issue looks different. AutoupgradeMixedContent upgrades all mixed content without consulting the https-everywhere list.

https-everywhere upgrades consults the https-everywhere DB for connection upgrades. This is an issue on iOS as well: brave/brave-ios#2554

I'm checking if this is limited to https-everywhere.

@jumde jumde changed the title [Android] Insecure icon shown on https pages [Android] Insecure icon displayed for https upgrades Jun 17, 2020
@srirambv
Copy link
Contributor

Removing from Android milestone based on discussion here https://bravesoftware.slack.com/archives/C0816QH3R/p1592419635325600

@srirambv srirambv removed this from the Android 1.10.x Release milestone Jun 18, 2020
@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes regression
Projects
None yet
Development

No branches or pull requests

6 participants