Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Follow up of #10064 - Reset rewards notification is shown forever even after resetting rewards #10935

Closed
GeetaSarvadnya opened this issue Jul 27, 2020 · 4 comments

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 27, 2020

Description

Follow up of #10064 - Reset rewards notification is shown forever even after resetting rewards

Steps to Reproduce

  1. Clean profile 1.12.x
  2. Enable rewards
  3. Click on settings icon in brave://rewards page and click on Reset option
  4. Click on Reset and ensure rewards reset notification is shown
  5. Repeat the steps 3 and 4 again
  6. Rewards reset notification is shown again and also encountered [Desktop]Follow up of #10064 - Rewards is turned off instead of reset when page is reloaded  #10934

Actual result:

Reset rewards notification is shown forever even after resetting rewards
image

Expected result:

Once the rewards is reset, rewards reset notification should be removed.

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.12.101 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Windows 10 OS Version 1903 (Build 18362.959)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @NejcZdovc

@srirambv
Copy link
Contributor

This is happening due to rewards not being reset. Once #10934 is fixed this would be obsolete as it will reset rewards

@NejcZdovc
Copy link
Contributor

let's retest when #10934 lands

@LaurenWags
Copy link
Member

Marking as QA/Blocked as this needs a new 1.12.x build to test

@GeetaSarvadnya
Copy link
Author

Verification passed on


Brave | 1.12.107 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)

  • Verified the test plan from Fix Rewards reset failing on Windows brave-core#6274 and STR from the issue
  • Ensured Rewards reset is working fine and after reset, rewards welcome page is displayed
    image
  • Verified that ads_service, rewards_service publisher_info_db and Rewards.log folders/files are removed from the profile folder
  • Verified that brave_rewards and brave_ads sections are removed from Preference file
  • Verified that rewards can be opt-in from brave://settings, BR panel and NTP widget and all the options are working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants