Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Implement fractional tipping amounts (e.g. 1.25 BAT) on Android #15618

Closed
stephendonner opened this issue May 4, 2021 · 2 comments
Closed
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include rewards-2.0

Comments

@stephendonner
Copy link

stephendonner commented May 4, 2021

Description

Implement fractional tipping amounts (e.g. 1.25 BAT) on Android (found while testing #15050)

Steps to reproduce

  1. clean profile
  2. launch Brave
  3. go to About > Settings > Developer Options > QA Preferences
  4. enter the QA code
  5. toggle Use Rewards staging server to On
  6. relaunch Brave
  7. enabled Rewards
  8. load 3zsistemi.si
  9. tap on the BAT icon in the URL bar
  10. take note of the default tipping values

Actual result

[1.000 BAT ] [5.000 BAT] [10.000 BAT]

Expected result

To match desktop, they should be -- for 3zsistemi.si at this time, on staging -- 1.25 BAT, for example

[1.25 BAT ] [5 BAT] [10.5 BAT]

Screen Shot 2021-05-04 at 12 43 05 PM

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? yes
  • Can you reproduce this issue with the current Play Store Beta version? yes
  • Can you reproduce this issue with the current Play Store Nightly version? yes

Device details

  • Install type (ARM, x86): arm64
  • Device type (Phone, Tablet, Phablet): Pixel XL
  • Android version: 9.0

Brave version

Brave 1.24.82, Chromium 90.0.4430.93

/cc @deeppandya @zenparsing

@stephendonner stephendonner added the OS/Android Fixes related to Android browser functionality label May 4, 2021
@anthonypkeane anthonypkeane added rewards-2.0 priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 23, 2021
@Miyayes Miyayes changed the title Implement fractional tipping amounts (e.g. 1.25 BAT) on Android [Android] Implement fractional tipping amounts (e.g. 1.25 BAT) on Android Jan 26, 2022
@Miyayes
Copy link
Collaborator

Miyayes commented Jan 26, 2022

I believe this is because the values are currently hardcoded on Android and aren't fetched. Will probably be solved with #17070

@Miyayes
Copy link
Collaborator

Miyayes commented Jul 14, 2022

Going to close this in favor of #17070, since this is a subset of #17070.

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include rewards-2.0
Projects
None yet
Development

No branches or pull requests

5 participants