Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shields 2.0 panel] Create mojom types and interfaces of the current shields api #18627

Closed
Tracked by #18630
nullhook opened this issue Oct 7, 2021 · 1 comment
Closed
Tracked by #18630

[Shields 2.0 panel] Create mojom types and interfaces of the current shields api #18627

nullhook opened this issue Oct 7, 2021 · 1 comment
Assignees
@nullhook
Labels
closed/works-for-me feature/shields/panel Front-end design and functionality of the Shields panel. OS/Desktop QA/No

Comments

@nullhook
Copy link

nullhook commented Oct 7, 2021 •
edited
Loading

Create necessary types and interfaces of the current shields api in a new mojom file ex: brave_shields.mojom

The current API: https://github.com/brave/brave-core/blob/master/common/extensions/api/brave_shields.json

This would get us ready for the implementation
@nullhook nullhook added QA/No release-notes/exclude feature/shields/panel Front-end design and functionality of the Shields panel. OS/Desktop labels Oct 7, 2021
@nullhook nullhook self-assigned this Oct 7, 2021
@rebron rebron mentioned this issue Oct 7, 2021
Closed
3 tasks
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 21, 2021
@rebron
Copy link
Collaborator

rebron commented Mar 17, 2022

Closing. Fixed with Shields v2.

@rebron rebron closed this as completed Mar 17, 2022
@rebron rebron added closed/works-for-me and removed release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nullhook nullhook

Labels
closed/works-for-me feature/shields/panel Front-end design and functionality of the Shields panel. OS/Desktop QA/No
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rebron @nullhook