Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global defaults link in the Shields panel is not visible for some screen sizes #22539

Closed
Tracked by #22546
MadhaviSeelam opened this issue Apr 25, 2022 · 3 comments
Closed
Tracked by #22546
Assignees
Labels
bug feature/shields The overall Shields feature in Brave. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@MadhaviSeelam
Copy link

Description

Global defaults link in the Shields panel is not visible on smaller screens

Steps to Reproduce

  1. Install 1.38.104
  2. Launch Brave
  3. Visit www.usatoday.com
  4. Click Shields icon to open Shields panel

Actual result:

Global defaults link is not visible in the Shields panel. (tested on my windows laptop)

small screens

Expected result:

Global defaults link should be available on smaller screens

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 1.38.104 Chromium: 101.0.4951.41 (Official Build) (64-bit)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS Windows 11 Version 21H2 (Build 22000.613)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron rebron mentioned this issue Apr 25, 2022
7 tasks
@rebron rebron assigned nullhook and unassigned rebron Apr 26, 2022
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 26, 2022
@btlechowski btlechowski changed the title Global defaults link in the Shields panel is not visible on smaller screens Global defaults link in the Shields panel is not visible for some screen sizes Apr 27, 2022
@btlechowski
Copy link

Also reproduced for 4k with default scale (300%)

shields 4k 300percent

@rebron
Copy link
Collaborator

rebron commented Jun 1, 2022

Closed with brave/brave-core#13209

@rebron rebron closed this as completed Jun 1, 2022
@rebron rebron added this to the 1.41.x - Nightly milestone Jun 1, 2022
@MadhaviSeelam
Copy link
Author

Verification PASSED using

Brave | 1.41.65 Chromium: 103.0.5060.42 (Official Build) nightly (64-bit)
-- | --
Revision | de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS | Windows 11 Version 21H2 (Build 22000.739)

Followed original steps

Confirmed Global defaults link is displayed on the Shields panel for smaller screen sizes

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/shields The overall Shields feature in Brave. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

4 participants