Skip to content

Add command line Brave Ads permission rule #23336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tmancey opened this issue Jun 8, 2022 · 1 comment · Fixed by brave/brave-core#13695
Closed

Add command line Brave Ads permission rule #23336

tmancey opened this issue Jun 8, 2022 · 1 comment · Fixed by brave/brave-core#13695

Comments

@tmancey
Copy link
Contributor

tmancey commented Jun 8, 2022

No description provided.

@btlechowski
Copy link

Verification passed on

Brave 1.42.74 Chromium: 103.0.5060.134 (Official Build) beta (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#13695

PASS --enable-features

NTP SI

[11717:11717:0721/130601.250033:VERBOSE2:permission_rule_util.cc(25)] --enable-features command-line arg is not supported
[11717:11717:0721/130601.252232:VERBOSE1:new_tab_page_ad_serving.cc(66)] New tab page ad not served: Not allowed due to permission rules

notification ads

[11717:11717:0721/130835.641485:VERBOSE2:permission_rule_util.cc(25)] --enable-features command-line arg is not supported
[11717:11717:0721/130835.649418:VERBOSE1:notification_ad_serving.cc(119)] Notification ad not served: Not allowed due to permission rules

inline ads

[11717:11717:0721/130945.410281:VERBOSE2:permission_rule_util.cc(25)] --enable-features command-line arg is not supported
[11717:11717:0721/130945.410393:VERBOSE1:inline_content_ad_serving.cc(68)] Inline content ad not served: Not allowed due to permission rules

PASS --force-fieldtrials and --force-fieldtrial-params

Command line used:

--force-fieldtrials="*UserActivity/Enabled" --force-fieldtrial-params="UserActivity.Enabled:idle_time_threshold/2s"

NTP SI

[15157:15157:0721/135935.363389:VERBOSE2:permission_rule_util.cc(25)] --enable-features command-line arg is not supported
[15157:15157:0721/135935.363953:VERBOSE1:new_tab_page_ad_serving.cc(66)] New tab page ad not served: Not allowed due to permission rules

notification ads

[14529:14529:0721/135359.006718:VERBOSE2:permission_rule_util.cc(25)] --enable-features command-line arg is not supported
[14529:14529:0721/135359.006932:VERBOSE1:notification_ad_serving.cc(119)] Notification ad not served: Not allowed due to permission rules

inline ads

[15157:15157:0721/140013.813477:VERBOSE2:permission_rule_util.cc(25)] --enable-features command-line arg is not supported
[15157:15157:0721/140013.814781:VERBOSE1:inline_content_ad_serving.cc(68)] Inline content ad not served: Not allowed due to permission rules

FAIL --variations-server-url and --variations-insecure-server-url

--variations-server-url - ads not blocked
command line: '--variations-server-url=https://www.google.com'
command line: --variations-server-url=https://variations.brave.com/seed

[15614:15614:0721/143554.859779:VERBOSE1:eligible_notification_ads_v1.cc(38)] Get eligible notification ads:
[15614:15614:0721/143554.863417:VERBOSE1:eligible_notification_ads_v1.cc(161)] Get eligible ads for untargeted segment

command line: --variations-insecure-server-url=http://localhost

[16722:16722:0721/144159.573397:VERBOSE1:eligible_notification_ads_v1.cc(38)] Get eligible notification ads:
[16722:16722:0721/144159.583716:VERBOSE1:eligible_notification_ads_v1.cc(161)] Get eligible ads for untargeted segment

command line: --fake-variations-channel=beta

[17307:17307:0721/144426.033649:VERBOSE2:permission_rule_util.cc(25)] --enable-features command-line arg is not supported
[17307:17307:0721/144426.044306:VERBOSE1:notification_ad_serving.cc(119)] Notification ad not served: Not allowed due to permission rules

Logged #24180

PASS --fake-variations-channel and --variations-override-country

`--variations-override-country=pl`
[17564:17564:0721/144804.265370:VERBOSE2:permission_rule_util.cc(25)] --enable-features command-line arg is not supported
[17564:17564:0721/144804.265619:VERBOSE1:notification_ad_serving.cc(119)] Notification ad not served: Not allowed due to permission rules

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants