-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for $removeparam filter syntax #23927
Comments
We can close this, we already have a ticket for this. brave/adblock-rust#166 No eta, but we are aware of it. cc: @antonok-edm |
Reopening this, since support is incoming in |
The above requires |
Verified
|
Brave | 1.47.123 Chromium: 108.0.5359.99 (Official Build) beta (x86_64) |
---|---|
Revision | 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9} |
OS | macOS Version 13.1 (Build 22C65) |
Used the testplan at brave/brave-core#15943 (comment)
Steps:
- saved HTML testcase as
index.html
- started server via
python3 -m http.server
- added filter rule of
localhost:8000^$document,removeparam=test
tobrave://settings/shields/filters
- clicked
Saved changes
- loaded
localhost:8000/index.html
- clicked on each of the 3 links
Confirmed the expected values for all 3 links were correct, as per the test plan
index.html |
brave://settings/shields/filters |
?test2=false |
(empty) |
?test2=false |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
Hi @Uni-verse, I came across the test you performed on Before opening a new issue, I wanted to check if you could re-test the feature and confirm whether it’s still working as expected on your end? Thank you for your time! |
Description
Several adblockers added the ability to remove URL parameters over the last few years, like uBlock Origin through the
$removeparam
filter. Allows to remove tracking/unnecessary URL parameters.Brave support is currently hardcoded to very select few parameters, thus making it impossible to use any list using this filter.
Steps to Reproduce
Brave version (brave://version info)
The text was updated successfully, but these errors were encountered: