Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave News Subscribe Button UX #25510

Closed
fallaciousreasoning opened this issue Sep 21, 2022 · 3 comments · Fixed by brave/brave-core#15149
Closed

Brave News Subscribe Button UX #25510

fallaciousreasoning opened this issue Sep 21, 2022 · 3 comments · Fixed by brave/brave-core#15149
Assignees
Labels
feature/brave-news formerly brave-today feature/user-interface All UI related OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude

Comments

@fallaciousreasoning
Copy link

fallaciousreasoning commented Sep 21, 2022

Now we have a lovely UX mockup for how the dialog should look the UI should be updated:

Figma Design

Dark Mode
image

Light Mode
image

@LaurenWags
Copy link
Member

@fallaciousreasoning could we get a test plan for this one please? Marking as QA/Blocked until we have that 👍🏻

cc @rebron @kjozwiak

@fallaciousreasoning
Copy link
Author

Added!

@stephendonner
Copy link

stephendonner commented Oct 27, 2022

Verified PASSED using

Brave 1.46.80 Chromium: 107.0.5304.68 (Official Build) beta (x86_64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 11.7.1 (Build 20G918)

Steps:

  1. installed 1.46.80
  2. launched Brave
  3. opened brave://flags
  4. set brave://flags/#brave-news-subscribe-button to Enabled
  5. set brave://flags/#brave-news-v2 to Enabled
  6. clicked Relaunch
  7. loaded theatlantic.com
  8. clicked on the Manage Subscriptions icon in the URL bar
  9. confirmed two feeds: Best of the Atlantic and The Atlantic
  10. clicked Follow on both (Unfollow Best of the Atlantic first, which comes by default with Top Sources)
  11. clicked Manage Feeds ->
  12. confirmed both showed up under Following
  13. clicked on Unfollow for Best of the Atlantic
  14. switched to theatlantic.com tab
  15. clicked again on the Manage Subscriptions icon
  16. clicked on Manage Feeds ->
  17. confirmed The Atlantic was listed, but not The Best of the Atlantic
  18. confirmed I got articles from The Atlantic
step 5 step 7 step 9 step 10 step 13 step 17 step 18 Light mode
Screen Shot 2022-10-26 at 6 43 40 PM Screen Shot 2022-10-26 at 6 52 10 PM Screen Shot 2022-10-26 at 6 53 26 PM Screen Shot 2022-10-26 at 6 53 55 PM Screen Shot 2022-10-26 at 6 54 28 PM Screen Shot 2022-10-26 at 6 55 18 PM Screen Shot 2022-10-26 at 6 55 48 PM Screen Shot 2022-10-26 at 6 56 50 PM

Logged:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/brave-news formerly brave-today feature/user-interface All UI related OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants