Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT images don't load on portfolio/panel when added without network #26388

Closed
srirambv opened this issue Oct 31, 2022 · 1 comment
Closed

NFT images don't load on portfolio/panel when added without network #26388

srirambv opened this issue Oct 31, 2022 · 1 comment
Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

NFT images don't load on portfolio/panel when added without network

Steps to Reproduce

  1. Disable network
  2. Add a bunch of NFT's to portfolio
  3. Doesn't show any image for NFT's
  4. Connect back to network
  5. Open the NFT, shows the NFT image
  6. Reload portfolio, doesn't load the image yet
  7. Open panel, doesn't show the NFT image

Actual result:

NFT.prview.in.Portfolio.and.panel.mp4

Expected result:

Should show the image when image metadata is loaded in NFT view details

Reproduces how often:

Brave version (brave://version info)

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Not checked

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @muliswilliam @nvonpentz

@srirambv srirambv added this to Web3 Oct 31, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Nov 4, 2022
@josheleonard josheleonard added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Apr 25, 2024
@josheleonard
Copy link

Closing - NFTs can no longer be added without first selecting a network from the dropdown

Image

@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
Archived in project
Development

No branches or pull requests

2 participants