Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of #26861: After removing custom filters and running the script, element blocks are still blocked #27243

Closed
MadhaviSeelam opened this issue Dec 8, 2022 · 4 comments
Assignees
Labels
bug closed/by-author features/shields/cosmetic-filtering OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release.

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Dec 8, 2022

Description

Steps to Reproduce

  1. Install 1.47.115
  2. launch Brave
  3. open brave://adblock and add following and click Save changes button
       ##.blocked-class-1
       ##.blocked-class-2
       ##.blocked-class-3
  1. visit example.com site
  2. Open dev tools console
  3. run the script in step 3 from Enable CosmeticFilteringJsPerformance by default #26861 (comment)
  4. wait till Done! Scroll to the end to check if there is any visible new element is shown in the console
  5. confirmed dynamically added blocks are blocked as expected
  6. return to brave://adblock and remove custom filters from above step 3
  7. click Save changes button
  8. refresh example.com site
  9. run the script from step 3
  10. wait till Done! Scroll to the end to check if there is any visible new element is shown in the console

Actual result:

Ex1 Ex2
image image

2022-12-08_12h29_15

Expected result:

The dynamically added elements blocks are not blocked

ex1 ex2 ex3 ex4
image image image image

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.47.115 Chromium: 108.0.5359.94 (Official Build) beta (64-bit)
-- | --
Revision | 713576b895246504ccc6b92c2fb8ce2d60194074-refs/branch-heads/5359_71@{#3}
OS | Windows 11 Version 21H2 (Build 22000.1219)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@antonok-edm @rebron

cc: @brave/qa-team

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 13, 2022
@rebron
Copy link
Collaborator

rebron commented Dec 13, 2022

@MadhaviSeelam Can you check to see if a browser restart, keeps the expected changes.

@MadhaviSeelam
Copy link
Author

@rebron I am still not seeing expected results after browser restart.

image

@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 13, 2022
@antonok-edm
Copy link
Collaborator

Actually... this might be an issue with the empty filters list. If a filter list is empty, it won't get updated when saving. This is because of a slightly hacky workaround that should be fixed when we merge brave/brave-core#16340.

@MadhaviSeelam if you'd like to confirm, try again but make sure the custom filters list isn't empty the second time. For example you could just add a single ! (comment character) in the box.

@MadhaviSeelam
Copy link
Author

MadhaviSeelam commented Jan 19, 2023

Closing this issue as it worked as expected with adding ! to the custom filter list (so not to have empty filter list)
(also just to confirm, verified the actual fix of brave/brave-core#16340 in 1.48.132)

ex1 ex2
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/by-author features/shields/cosmetic-filtering OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release.
Projects
None yet
Development

No branches or pull requests

4 participants