Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension update requests are sent in JSON are not handled correctly #3258

Closed
jumde opened this issue Feb 7, 2019 · 1 comment · Fixed by brave/brave-core#1602
Closed

Comments

@jumde
Copy link
Contributor

jumde commented Feb 7, 2019

From: brave/go-update#17

Description

Requests to update extensions are sent in JSON instead of XML. These requests are not handled correctly by go-updater.

Test Plan

See issue: brave/brave-core#1602

Steps to Reproduce

  1. Run go-updater locally
  2. Try updating extensions
  3. See update request in JSON

Actual result:

Update request in JSON

Expected result:

Update request in XML

Reproduces how often:

Easily

Brave version (brave://version info)

master

@srirambv
Copy link
Contributor

srirambv commented Feb 20, 2019

Verification passed on

Brave 0.60.40 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Linux

Verification passed on

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Windows 10

Before update:
image

After Update:
image

Verified passed with

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Mac OS X

screen shot 2019-02-21 at 3 29 55 pm

Extensions after update:
screen shot 2019-02-21 at 3 30 21 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment