Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave shields notification icon is not scaled for double digits #3434

Closed
btlechowski opened this issue Feb 20, 2019 · 1 comment
Closed

Brave shields notification icon is not scaled for double digits #3434

btlechowski opened this issue Feb 20, 2019 · 1 comment
Labels
closed/invalid design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. priority/P4 Planned work. We expect to get to it "soon".

Comments

@btlechowski
Copy link

Follow up from #2295

Steps to Reproduce

  1. Open a stream on twitch.tv

Actual result:

The notification icon width for double digits is 12px
image

Expected result:

The notification icon width for double digits is 14px
notificationspec

Check comment: #2295 (comment)

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Windows 7

cc @brave/legacy_qa @petemill @rossmoody
@btlechowski btlechowski added design A design change, especially one which needs input from the design team QA/Yes QA/Test-Plan-Specified feature/shields/panel Front-end design and functionality of the Shields panel. labels Feb 20, 2019
@btlechowski btlechowski mentioned this issue Feb 20, 2019
Closed
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Feb 26, 2019
@rossmoody
Copy link
Contributor

We can close this one down. I tried to be as precise as possible with my pixel increments but in the end @petemill was able to responsively size that notification bubble based on text width. If you hit a 7 digit it'll go to to 14px. If we're ever fortunate enough to get to 99+ I believe the font decreases in size as well.

screen shot on 2019-02-27 at 20 15 57

@rebron rebron added this to the Dupe / Invalid / Not actionable milestone Mar 13, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/invalid design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bbondy @rebron @rossmoody @btlechowski